Nested GraphQL fragments are not processed by the Catalog Attribute Joiner

[pmzandbergen]

Preconditions and environment

• Magento 2.4.7

Steps to reproduce

Using a GraphQL fragment inside another fragment does not work. Example query:

query {
  products(filter: { sku: { eq: "example-product" } }) {
    items {
      ... on ProductInterface {
        ...ProductInterfaceFragment
      }
    }
  }
}
fragment ProductFragment on ProductInterface {
  sku
  ...AnotherProductFragment
}
fragment AnotherProductFragment on ProductInterface {
  url_key
}

In this case the Attribute Joiner (Magento\CatalogGraphQl\Model\AttributesJoiner) will return the following fields:

• sku
• AnotherProductFragment (which is not a field, its a fragment)

The result will not return a value for url_key, since the attribute is not queried.

Expected result

The result will include the fields from all (nested) fragments (sku and url_key in this example).

Actual result

The result includes only the fields from the first (not nested) fragment, url_key is undefined.

Additional information

I'll create a PR fixing the Attribute Joiner to support nested fragments.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @pmzandbergen. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Bravo, here is your Magento Instance: https://9aa2bfe654ae79ee312741bd73c969c9.instances-prod.magento-community.engineering Admin access: https://9aa2bfe654ae79ee312741bd73c969c9.instances-prod.magento-community.engineering/admin_1fd0 Login: fddd306a Password: 0f9f2275cbf2

[engcom-Bravo]

Hi @pmzandbergen,

Thanks for your reporting and collaboration.

We have verified the issue in Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

The result included the fields from all (nested) fragments (sku and url_key)

Thanks.

[engcom-Bravo]

Hi @pmzandbergen,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.