Error on adminhtml popup product grids (e.g. adding Simple Product to Grouped Product)

densen45 commented 5 months ago

Preconditions and environment

Magento version 2.4.7
PHP 8.2

Steps to reproduce

Open or create a Grouped Product
Scroll down and click "Add Products to Group"
Wait until the grid is loaded

This issue also occurs on the Bundle Product page "Add Products to Option".

Expected result

The pop up displays without any error.

Actual result

The following error is shown in the browser: A technical problem with the server created an error. Try again to continue what you were doing. If the problem persists, try again later.

The following warning can be found in the system.log: main.ERROR: Warning: Undefined array key "filters" in /path/to/magento/vendor/magento/module-ui/Controller/Adminhtml/Bookmark/Save.php on line 250 [] []

Additional information

In the Save.php on line 250 it is expected, that the two arrays $existingConfig and $currentConfig contains a key called filters. This part is new in 2.4.7 and was not present in 2.4.6-p4. Both arrays don't contain the filters key on these 'pop up product grids', however the key exists in both variables on e.g. the Product Grid (Catalog > Products). I guess this is because the filter for the Product Grid is saved for later visits, but for the ‘pop-up product tables’ the filter is never saved.

I have not noticed any restrictions due to this error. The filter works as expected and once you have set a filter, the error is no longer displayed.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[X] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 5 months ago

Hi @densen45. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

densen45 commented 5 months ago

@magento give me 2.4.7 instance

magento-deployment-service[bot] commented 5 months ago

Hi @densen45. Thank you for your request. I'm working on Magento instance for you.

m2-assistant[bot] commented 5 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-deployment-service[bot] commented 5 months ago

Hi @densen45, here is your Magento Instance: https://a3f8bcd7c487a9e9a30d9a52c1f62d45.instances-prod.magento-community.engineering Admin access: https://a3f8bcd7c487a9e9a30d9a52c1f62d45.instances-prod.magento-community.engineering/admin_5aa1 Login: 9ea16fde Password: f8d88b45e9ff

densen45 commented 5 months ago

I was able to reproduce this issue on the provided Magento instance for both, Grouped and Bundle Products.

Grouped Product: Bildschirmfoto vom 2024-05-30 12-34-00

Bundle Product: Bildschirmfoto vom 2024-05-30 12-35-47

engcom-Bravo commented 5 months ago

Hi @densen45,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

The following error is shown in the browser:

A technical problem with the server created an error. Try again to continue what you were doing. If the problem persists, try again later.

The following warning can be found in the system.log :

main.ERROR: Warning: Undefined array key "filters" in /usr/local/var/www/magentop/magento2/app/code/Magento/Ui/Controller/Adminhtml/Bookmark/Save.php on line 250 [] []

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 5 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12048 is successfully created for this GitHub issue.

m2-assistant[bot] commented 5 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

rogerdz commented 5 months ago

It error only first time, I can duplicate by remove grouped_product_listing in ui_bookmark and reload admin product page

gwharton commented 4 months ago

I see these pop up all the time in my logs. And not just on that page too.

[2024-07-15T07:52:59.721745+00:00] main.ERROR: Warning: Undefined array key "filters" in /home/ubuntu/production/vendor/magento/module-ui/Controller/Adminhtml/Bookmark/Save.php on line 250 [] []