magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Configurable product regular price shown including tax while configured to show prices without tax #38800

Open oskar-olaussen opened 4 months ago

oskar-olaussen commented 4 months ago

Preconditions and environment

Magento version 2.4.6-p2

Tax class "Taxable Goods" set with some tax rate. I used 24%.

Tax settings: tax/calculation/price_includes_tax set to 1 (Catalog prices: Including tax) tax/display/type set to 1 (Display Product Prices In Catalog: Excluding tax)

Steps to reproduce

  1. Tax class "Taxable Goods" set to some configurable child.
  2. Set a special price for that configurable child.
  3. Reindex
  4. Navigate to the configurable product page and select the child product.

Expected result

The child's regular price is shown excluding tax.

Actual result

The child's regular price is shown including tax.

Here are the prices set in the admin: Screenshot from 2024-06-05 15-36-54 Screenshot from 2024-06-05 15-36-39

Here is what is shown on the front end: Screenshot from 2024-06-05 15-38-02

The regular price should be shown excluding the tax but is shown including the tax instead.

Additional information

One possible fix would be to get the value excluding tax here: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php#L299

Release note

No response

Triage and priority

m2-assistant[bot] commented 4 months ago

Hi @oskar-olaussen. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 4 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

m2-assistant[bot] commented 4 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


engcom-Dash commented 4 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 4 months ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 4 months ago

Hi @engcom-Dash, here is your Magento Instance: https://140446ec3105a28caa21c3d7b15762f4.instances-prod.magento-community.engineering Admin access: https://140446ec3105a28caa21c3d7b15762f4.instances-prod.magento-community.engineering/admin_07ae Login: cfad4523 Password: 77c114e64b51

engcom-Dash commented 3 months ago

Hi @oskar-olaussen

Thanks for reporting and collaboration.

Verified the issue on Magento 2.4 dev instance but the issue is not reproducable.

The child's regular price is shown excluding tax.

Tax class "Taxable Goods" set with some tax rate. I used 24%.

Tax settings: tax/calculation/price_includes_tax set to 1 (Catalog prices: Including tax) tax/display/type set to 1 (Display Product Prices In Catalog: Excluding tax)

Steps to reproduce Tax class "Taxable Goods" set to some configurable child. Set a special price for that configurable child. Reindex Navigate to the configurable product page and select the child product.

Please refer the attached screenshots. Let us know if we missed anything.

Screenshot 2024-06-11 at 3 42 12 PM Screenshot 2024-06-11 at 3 42 44 PM Screenshot 2024-06-11 at 4 12 21 PM Screenshot 2024-06-07 at 11 20 15 AM Screenshot 2024-06-07 at 11 20 17 AM Screenshot 2024-06-11 at 4 20 08 PM Screenshot 2024-06-11 at 4 12 21 PM
oskar-olaussen commented 3 months ago

Hello @engcom-Dash

Sorry if I'm misunderstanding something, but your screenshot seems to verify to issue? The price in admin is 1000 and the configuration is that the admin price includes the tax. The frontend show the regular price as 1000 but according to the configurations it should be shown excluding the tax.

engcom-Dash commented 3 months ago

Hi @oskar-olaussen

Thanks for reporting and collaboration.

I verified the issue on Magento 2.4 dev instance but the issue is reproducible.

Hence, Confirming the issue.

The child's regular price is shown including tax.

Tax class "Taxable Goods" set with some tax rate.

Screenshot 2024-06-11 at 3 42 12 PM Screenshot 2024-06-11 at 3 42 44 PM

Tax settings: tax/calculation/price_includes_tax set to 1 (Catalog prices: Including tax) tax/display/type set to 1 (Display Product Prices In Catalog: Excluding tax)

Steps to reproduce:

  1. Tax class "Taxable Goods" set to some configurable child.
  2. Set a special price for that configurable child.
  3. Reindex
  4. Navigate to the configurable product page and select the child product.

Please take a look at the screenshots I've attached.

Screenshot 2024-06-11 at 4 12 21 PM Screenshot 2024-06-07 at 11 20 15 AM Screenshot 2024-06-07 at 11 20 17 AM Screenshot 2024-06-11 at 4 20 04 PM
github-jira-sync-bot commented 3 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12131 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 months ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.