[Issue] avoid a misconfiguration infinite loop

[m2-assistant[bot]]

This issue is automatically created based on existing pull request: magento/magento2#38794: avoid a misconfiguration infinite loop

---

Description (*)

The virtual type configurations, in di.xml files, are not supposed to be self‑referential, … but if they ever are this function will spin in an infinite loop.

Changes

Added a test to avoid a self‑referential mapping, returning the self‑reference instead of endlessly spinning.

Fixed Issues (if relevant)

unknown

Manual testing scenarios (*)

Configure a di.xml <virtualType …> node to be self‑referential (i.e. not actually virtual). This will cause the app to spin, infinitely, on the dereferencing attempt. Note that the self‑reference can be from a chain of <virtualType …> nodes and not just a single node.

Contribution checklist (*)

• [√] Pull request has a meaningful description of its purpose
• [√] All commits are accompanied by meaningful commit messages
• [n/a] All new or changed code is covered with unit/integration tests (if applicable)
• [n/a] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [unknown] All automated tests passed successfully (all builds are green)

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @ergohack,

Thank you for the report and collaboration!

Going through the pr changes this issue can be confirmed.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12127 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.