[Bug] Magento 2.4.7 doesn't allow product photo's with capital letter file extension.

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.5k stars 9.3k forks source link

[Bug] Magento 2.4.7 doesn't allow product photo's with capital letter file extension. #38831

Closed phol closed 1 month ago

phol commented 3 months ago

Preconditions and environment

Magento version 2.4.7

Steps to reproduce

Create a new product
Try to upload a picture with e.g. filename DSCN0018.JPG. The upload will fail.
Change the filename to DSCN0018.jpg. The upload succeeds.

Expected result

Image uploads with capital letter file extensions don't cause an error.

Actual result

After upgrading to 2.4.7, Image uploads with capital letter file extensions are refused.

Additional information

No response

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[x] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 months ago

Hi @phol. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

phol commented 3 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 months ago

Hi @phol. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 months ago

Hi @phol, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

phol commented 3 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 months ago

Hi @phol. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 months ago

Hi @phol, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

m2-assistant[bot] commented 3 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] commented 3 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 3 months ago

Hi @phol

Thanks for reporting and collaboration.

Verified the issue on Magento 2.4 dev instance and the issue is reproducible.

Note : Verified the issue in 2.4.6 and the issue is not reproducable. We are able to upload files with capital letters.

Getting "Disallowed file type: when we try to upload product photo with capital letter file extension.

Steps to reproduce

Create a new product
Try to upload a picture with e.g. filename DSCN0018.JPG. The upload will fail.
Change the filename to DSCN0018.jpg. The upload succeeds.

Please take a look at the screenshots I've attached.

File with capital letters in the extension only :

File with capital letters in the file name and in the extension:

In 2.4.6 we can successfully upload file with capital letters in extensions.

github-jira-sync-bot commented 3 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12167 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 months ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

monteshot commented 2 months ago

@magento I am working on this

engcom-Bravo commented 2 months ago

Hello,

Internal team has started to work on it.

Thanks.

engcom-Bravo commented 1 month ago

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-12167 by the internal team Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-12167&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks

magento / magento2

[Bug] Magento 2.4.7 doesn't allow product photo's with capital letter file extension. #38831

Preconditions and environment

Steps to reproduce

Expected result

Actual result

Additional information

Release note

Triage and priority

To learn more about issue processing workflow, refer to the Code Contributions.