Admin captcha does not load due to CSP when admin and store base_url are different.

damienwebdev commented 4 months ago

Preconditions and environment

No response

Steps to reproduce

Set your store's id 1' base_url to "magento2.test"
Set your admin store url to "admin.magento2.test"
Attempt to sign in enough to trigger captcha

Expected result

See a captcha

Actual result

See:

Console contains

Refused to load the image 'magento2.test' because it violates the following Content Security Policy directive: "img-src assets.adobedtm.com amcglobal.sc.omtrdc.net dpm.demdex.net cm.everesttech.net .adobe.com amasty.com www.googleadservices.com www.google-analytics.com googleads.g.doubleclick.net www.google.com bid.g.doubleclick.net analytics.google.com www.googletagmanager.com .ftcdn.net .behance.net data: t.paypal.com www.paypal.com www.paypalobjects.com fpdbs.paypal.com fpdbs.sandbox.paypal.com .vimeocdn.com i.ytimg.com .youtube.com validator.swagger.io store.paradoxlabs.com www.sandbox.paypal.com b.stats.paypal.com dub.stats.paypal.com assets.braintreegateway.com c.paypal.com checkout.paypal.com .paypal.com *.aptrinsic.com storage.googleapis.com data: 'self' 'unsafe-inline'".

Additional information

You can circumvent the issue by opening the captcha url in a new tab, but that's not great.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 months ago

Hi @damienwebdev. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 4 months ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Delta commented 4 months ago

Hi @damienwebdev ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and the issue is not reproducible. Kindly refer the screenshots.

Steps to reproduce

Access Adobe Commerce Admin.
Navigate to Stores>Settings>Configuration
In configuration page, click on Advanced>Admin
To Change base url, Set the “Use custom admin url” to “Yes”
Enter the new admin url in “Custom Admin URL” field
Now, Click on save config
Clear the Cache from System > Tools > Cashe Management
User will be logged-out automatically.
Access the admin url and enter invalid credentials multiple times.
Observe Captcha Displays when user enters invalid credentials multiple times. Captcha is displaying as expected, User is also able to login with valid credentials and captcha. Please let us know if we missed anything.

Thanks.

engcom-Delta commented 3 months ago

Hi @damienwebdev ,

We have noticed that this issue has not been updated since long time. Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

damienwebdev commented 2 months ago

@engcom-Delta please reopen. There's an additional configuration necessary to trigger this result.

Add the following CSP Configuration:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Store:etc/config.xsd">
    <default>
        <csp>
            <mode>
                <storefront>
                    <report_only>0</report_only>
                </storefront>
                <admin>
                    <report_only>0</report_only>
                </admin>
            </mode>
        </csp>
  </default>
</config>

If you use strict CSP, media in the admin panel do not work as they are loaded from the storefront's domain as opposed to the admin domain.

The root cause is that the https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Store/Model/StoreResolver.php#L95 returns 1 for the admin store instead of 0.

magento / magento2