Dashboard Order graph animates into final size

vandijkstef commented 4 months ago

Preconditions and environment

Mage 2.4.7

Steps to reproduce

Since updating to Mage 2.4.7 the Orders/Amounts graph on the admin dashboard page is quite slowly animating into it's final size. It seems like the animation timing that is applied to the canvas element contents is ALSO applied to the canvas element itself.

It's apparent on first-load ánd when switching between a non-data selection (today when no order received today) and actual-data selection (YTD wíth orders)

It's also apparent when (rapidly) changing the width of the page

Expected result

canvas element snapping between max-size and min-size - an instant layout-shift, not animated over 1-2s
or -
No layout shift at all - Element stays max-sized and show a 'No data found'-like warning message

I would prefer the latter, as pages moving without users explicit input should be prevented but it might break the scope of this bug and become a change of an existing feature.

Actual result

The graph starts out as an very small (0 x 0 px size) element and animates into it's final size.

Additional information

I am pretty sure this is coming from the JS that is rendering the graph - Adding animation: none and transition: 0s to the canvas element doesn't change the behaviour

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 months ago

Hi @vandijkstef. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

vandijkstef commented 4 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 4 months ago

Hi @vandijkstef. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 4 months ago

Hi @vandijkstef, here is your Magento Instance: https://2927213243607cd551924ed1eaacd514.instances-prod.magento-community.engineering Admin access: https://2927213243607cd551924ed1eaacd514.instances-prod.magento-community.engineering/admin_11e4 Login: 52c69810 Password: 2a6c8f595705

vandijkstef commented 4 months ago

Issue reproducible on 2.4-develop instance.

Just 'enable charts', flush config cache and navigate back to dashboard to see it in action.

Minor addition: tested in Chrome 126

m2-assistant[bot] commented 4 months ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Dash commented 3 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 months ago

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 months ago

Hi @engcom-Dash, here is your Magento Instance: https://2927213243607cd551924ed1eaacd514.instances-prod.magento-community.engineering Admin access: https://2927213243607cd551924ed1eaacd514.instances-prod.magento-community.engineering/admin_6a69 Login: 9e011de0 Password: 23c4b85f2087

engcom-Dash commented 3 months ago

Hi @vandijkstef

Thanks for reporting and collaboration.

Verified the issue on Magento 2.4 dev instance, 2.4.7 and in 2.4.7 after upgrading the instance and the issue is reproducable.

Hence, confirming the issue.

Dashboard Order graph animates into final size

Please refer the attached screen recordings.

https://github.com/magento/magento2/assets/60198592/ab99a103-1290-4877-a6b2-335d2395a52c

https://github.com/magento/magento2/assets/60198592/3248d2a3-9d5b-4530-a0c9-5b6698ae8c1d

https://github.com/magento/magento2/assets/60198592/0539623c-9a87-4ba6-8a99-1d04daf8e3de

github-jira-sync-bot commented 3 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12300 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 months ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

SerhiiMandrykin commented 1 month ago

Hi @engcom-Dash, are there any updates on this issue? We encounter the same.

Kroellie commented 1 day ago

This is really annoying, and feels like an over-engineered thing to begin with. I can't imagine the problem would be that hard to fix, and with that said I also can't imagine it being on the low priority.

magento / magento2