magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Pagebuilder Maps script should not be output when Page builder is disabled #38872

Closed Detzler closed 4 months ago

Detzler commented 4 months ago

Preconditions and environment

Steps to reproduce

  1. Login to Backend
  2. Navigate to Stores > Configuration > General > Content Management
  3. Set "Enable Page Builder" to No
  4. Leave Google Maps API Key empty
  5. Save settings

Expected result

  1. Value for key "cms/pagebuilder/google_maps_api_key" in core_config_data table should be NULL or empty (I don't know exactly)
  2. Script tag should not be output image

Actual result

  1. Value for key "cms/pagebuilder/google_maps_api_key" in core_config_data table is a string containing "NULL (NULL/"unknown" value)" image
  2. Script tag is output because of the condition that gmaps api key is not empty image image image

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 4 months ago

Hi @Detzler. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 4 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 4 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 4 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 4 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://c7759a78f87bb08514317b6b275436fa.instances-prod.magento-community.engineering Admin access: https://c7759a78f87bb08514317b6b275436fa.instances-prod.magento-community.engineering/admin_a9cd Login: b0727001 Password: 822ef41f3d1c

engcom-Bravo commented 4 months ago

Hi @Detzler,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screnshots.

Steps to reproduce

Screenshot 2024-06-26 at 10 38 42 Screenshot 2024-06-26 at 10 38 25

cms/pagebuilder/google_maps_api_key" in core_config_data table having NULL value.

Thanks.

engcom-Bravo commented 4 months ago

Hi @Detzler,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.