magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.44k stars 9.29k forks source link

Paypal Braintree - Stored Payment Methods page error when disabled Telephone field #38903

Closed khoimm92 closed 1 month ago

khoimm92 commented 1 month ago

Preconditions and environment

Steps to reproduce

From frontend:

Expected result

Can add a new Card.

Actual result

There's an error on Console window, but the message is not clear: image

When clicking Add new Credit Card, there's no Address form, and infinitive loading once submitting, also a new error on Console window: image

Additional information

Although the error message is not helpful, I've spotted the flaw code in: vendor/paypal/module-braintree-core/view/frontend/web/js/customer/modals/address-modal.js image

telephone: document.getElementById('telephone').value, This line breaks the process of rendering Address form.

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 month ago

Hi @khoimm92. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 month ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


engcom-Dash commented 1 month ago

Hi @khoimm92

Thanks for reporting and collaboration.

Verified the issue on the Magento 2.4 dev instance and the issue is not reproducible.

Steps to reproduce In Admin, disable the Customer Telephone field by: Store -> Configuration -> Customers -> Customer Configuration -> Name and Address Options -> Set Show Telephone to No

Able to store the payment methods page when the telephone field is disabled.

Please take a look at the screenshots I've attached.

When the telephone field is disabled.

38903_1

On UI when new cards are added successfully.

38903_2
engcom-Dash commented 1 month ago

Hi @khoimm92

We have noticed that this issue has not been updated for a long time.
Hence we assume this issue is fixed now, so we are closing it. Please feel free to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.