magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Cannot change intermediate custom status in admin using add comment form #38917

Closed zakdma closed 2 months ago

zakdma commented 4 months ago

Preconditions and environment

Steps to reproduce

  1. Install vanilla Magento
  2. Go to admin Stores => Order Status
  3. Create two statuses "Sent" and "Ready for Pickup" and bind them to "Processing" state
  4. Create product and register customer
  5. Place order on front using this product and customer and default shipping and payment methods
  6. Go to admin Sales => Orders
  7. Open previously placed order
  8. Create invoice by clicking Invoice button on top
  9. See order changed status to "Processing"
  10. Go to "Add Comment" form change status to "Sent" and add any comment
  11. Reload order form and see status changed to "Sent"
  12. Go to "Add Comment" form again and change status to "Ready for Pickup" and add any comment
  13. Reload order form

Expected result

See status is changed to "Ready for Pickup"

Actual result

See status is still "Sent"

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 4 months ago

Hi @zakdma. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 4 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 4 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 4 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 4 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://5e5b258c627b4317f1ba746fbda8c703.instances-prod.magento-community.engineering Admin access: https://5e5b258c627b4317f1ba746fbda8c703.instances-prod.magento-community.engineering/admin_e21e Login: c76b96f0 Password: b93f2f60ca26

engcom-Bravo commented 4 months ago

Hi @zakdma,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the attached video.

Steps to reproduce

https://github.com/user-attachments/assets/44b40e2a-9256-426d-ac9e-0ae0d43e422d

The Status is still in sent state.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 4 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12462 is successfully created for this GitHub issue.

m2-assistant[bot] commented 4 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

simonmaass commented 4 months ago

does anyone know why this change was introduced in the first place?

simonmaass commented 4 months ago

i guess this was why: https://github.com/magento/magento2/issues/36562

engcom-Bravo commented 2 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://5e5b258c627b4317f1ba746fbda8c703.instances-prod.magento-community.engineering Admin access: https://5e5b258c627b4317f1ba746fbda8c703.instances-prod.magento-community.engineering/admin_9e52 Login: 72ce59df Password: f723c7fd67d9

hostep commented 2 months ago

Possibly fixed by https://github.com/magento/magento2/commit/18dee3d979ed8ee68a44324e892e6b7f570c987c?

engcom-Bravo commented 2 months ago

@hostep Thanks for your Contribution!!.

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket ACP2E-3178 by the internal team Related commits: https://github.com/search?q=repo%3Amagento%2Fmagento2+ACP2E-3178&type=commits

Based on the Jira ticket, the target version is 2.4.8-beta1.

Thanks

hostep commented 2 months ago

Thanks for confirming @engcom-Bravo, can you also close https://github.com/magento/magento2/issues/38659, which is a duplicate of this issue here? Thanks!

simonmaass commented 2 months ago

great - so will have this fix in april 2025!