magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Inaccurate doc block comment in Product Stock and Price Alerts #38939

Open brian-labelle opened 3 months ago

brian-labelle commented 3 months ago

The following doc block comment is incorrect:

\Magento\ProductAlert\Model\Stock::deleteCustomer

See also: \Magento\ProductAlert\Model\Price::deleteCustomer

"Method for deleting customer from website."

This method does not delete the customer from the website. It deletes all stock product / price alerts associated with the given customer and website

m2-assistant[bot] commented 3 months ago

Hi @brian-labelle. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 3 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 3 months ago

Hello @brian-labelle,

Thank you for the report and collaboration!

Yes the doc block description are incorrect for Magento\ProductAlert\Model\Stock::deleteCustomer and Magento\ProductAlert\Model\Price::deleteCustomer, hence confirming this issue.

github-jira-sync-bot commented 3 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12540 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.