[Issue] Remove references to files from extjs which got removed in e1ccdb…

m2-assistant[bot] commented 1 month ago

This issue is automatically created based on existing pull request: magento/magento2#38951: Remove references to files from extjs which got removed in e1ccdb…

…83e7e312572038c476d0695300700db849

Description (*)

While running Magento 2.4-develop locally, I noticed some errors both in my brower's console and the var/log/system.log file:

[2024-07-18T14:31:10.013255+00:00] main.ERROR: Compilation from source: LESS file is empty: adminhtml/Magento/backend/en_US/extjs/resources/css/ytheme-magento.less [] []
[2024-07-18T14:31:10.013254+00:00] main.ERROR: Compilation from source: LESS file is empty: adminhtml/Magento/backend/en_US/extjs/resources/css/ext-all.less [] []

After some searching around, it looks like the entire directory lib/web/extjs got removed in e1ccdb83e7e312572038c476d0695300700db849

It looks like @Atul-glo35265 didn't notice there were still references to some of those files in the codebase, which were still being used in the backoffice.

This PR cleans up those references.

The removal of the phtml file is because it also referenced extjs, so it would also no longer work, and it seems the file is not being used (at least not in Magento OS). From the commit message that introduced the file, I think this may have been used in Adobe Commerce since they mention a Banner Rotation Widget, which doesn't exist in Magento OS. But since this commit is 9 years old, I have no idea if that still exists. And maybe it was also refactored recently in Adobe Commerce to no longer use the extjs files? Maybe somebody with access to Adobe Commerce source code can double check this?

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Open the backoffice
See if there are errors in your browsers console about trying to load css files from extjs
See in your var/log/system.log if there are errors about empty less files from extjs

Questions or comments

Preferably, this PR should be included in whatever next Magento release (2.4.8?) together with the changes from e1ccdb83e7e312572038c476d0695300700db849

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] commented 1 month ago

Hi @engcom-Dash. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Hotel commented 1 month ago

Confirming this issue for further processing.

github-jira-sync-bot commented 1 month ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12597 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 month ago

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento / magento2