Missing tax from Grand Total for Invoice created in the admin manually, and order shows an amount due when it should not

[xtremevision]

Preconditions and environment

• Magento version: 2.4.3-p3
• Order contained 3 items: 2 simple products & 1 virtual
• Payment was done by credit card, for the entire order amount
• Two invoices were created in the admin: 1 for the simple products & 1 for the virtual
• The grand total is less than the subtotal for the invoice with the simple products. The amount invoiced is missing the tax amount.
• Tax is set to 5% for these products (reduced)

Steps to reproduce

1. Add 2 simple products to the cart
2. Add 1 virtual product to the cart
3. Checkout
4. Pay with Credit Card - in authorize mode only
5. In admin create two invoices as per above

Expected result

Grand total should match the subtotal, i.e. contain the tax amount.

Actual result

Invoiced amount is incorrect, it is less than the subtotal, i.e. missing the tax amount. Looks like invoiced amount is short by 0.72 lei, i.e. the tax amount that belongs to the second invoice for the virtual product.

Additional information

No response

Release note

No response

Triage and priority

• [X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @xtremevision. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[xtremevision]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @xtremevision. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @xtremevision, here is your Magento Instance: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering Admin access: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering/admin_4146 Login: e63059b6 Password: c74abb791cda

[xtremevision]

Hi, what happened to the instance? I managed to set it up, test an order and now it's gone.

[xtremevision]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @xtremevision. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @xtremevision, here is your Magento Instance: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering Admin access: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering/admin_488e Login: 506f4b27 Password: 9756255980e0

[xtremevision]

@magento I am working on this

[m2-assistant[bot]]

Hi @xtremevision! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Delta, here is your Magento Instance: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering Admin access: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering/admin_6855 Login: 8a993e22 Password: 07c43ef5db5f

[engcom-Delta]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Delta, here is your Magento Instance: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering Admin access: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering/admin_65a3 Login: 4964b17c Password: 2bb478419df2

[engcom-Delta]

@magento give me 2.4-develop instance

[magento-deployment-service[bot]]

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service[bot]]

Hi @engcom-Delta, here is your Magento Instance: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering Admin access: https://4e955af351135d451f98c5d8e6695bcf.instances-prod.magento-community.engineering/admin_8bc2 Login: 40819a46 Password: 6aa803eef105

[engcom-Delta]

Hi @xtremevision ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and the issue is not reproducible. Kindly refer the screenshots.

Steps to Reproduce -

1. Add 2 Simple products to the cart.
2. Add 1 Virtual product to the cart.
3. Set 5% tax
4. Navigate to cart and observe the subtotal and tax.
5. Place order successfully.
6. Create 2 invoices, 1st for simple products and 2nd for virtual product. Invoice 1st Invoice 2nd
7. Observe the order total calculation should be as expected after invoice creation. Total Due is 0 as expected after both invoice creation. Please let us know if we missed anything.

Thanks.

[xtremevision]

@engcom-Delta Hi, and thank you for taking the time to work on this. I did the same test and could not reproduce the problem following the above steps. However, in the meantime I've discovered the following:

1. There is an "Auto Invoice" module in place that automatically creates invoices for virtual products - paid by credit card.
2. The Virtual product invoice was automatically created by the module - first.
3. The Simple products invoice was created manually by admin staff - after the virtual products invoice.
4. The Simple products were also shipped, see screenshot.

Something is going on, somewhere, I just have not found out exactly what and where. Could it be we're not creating the invoice correctly?

[xtremevision]

We use a plugin to intercept the payment method's IPN (credit card) and instead of creating one invoice for the order, we create a partial invoice only for virtual products, letting the admin staff create invoices for simple products.

Is there anything wrong with the invoice creationg code by any chance?

<?php

namespace Xtreme\AutoInvoice\Gateway\Command\Ipn;

use Innobyte\PayU\Gateway\Helper\SubjectReader;
use Innobyte\PayU\Model\Config\Source\PaymentAction;
use Magento\Payment\Gateway\CommandInterface;
use Magento\Payment\Gateway\ConfigInterface;
use Magento\Payment\Gateway\Helper\ContextHelper;
use Magento\Payment\Gateway\Response\HandlerInterface;
use Magento\Sales\Api\OrderRepositoryInterface;
use Magento\Sales\Model\Order\Email\Sender\InvoiceSender;
use Magento\Sales\Model\Order\Email\Sender\OrderSender;
use Magento\Sales\Model\Service\InvoiceService;
use Magento\Framework\DB\Transaction;

class CaptureStrategyCommandPlugin extends \Innobyte\PayU\Gateway\Command\Ipn\CaptureStrategyCommand
{
    /**
     * @var SubjectReader
     */
    private $subjectReader;

    /**
     * @var HandlerInterface
     */
    private $handler;

    /**
     * @var \Innobyte\PayU\Gateway\Config\Config
     */
    private $config;

    /**
     * @var OrderRepositoryInterface
     */
    private $orderRepository;

    /**
     * @var OrderSender
     */
    private $orderSender;

    /**
     * @var InvoiceSender
     */
    private $invoiceSender;

    protected $transaction;
    protected $invoiceService;

    /** @var \Magento\Eav\Api\AttributeSetRepositoryInterface $attributeSet **/
    protected $attributeSet;

    /**
     * CaptureStrategyCommand constructor
     *
     * @param SubjectReader $subjectReader
     * @param HandlerInterface $handler
     * @param ConfigInterface $config
     * @param OrderRepositoryInterface $orderRepository
     * @param OrderSender $orderSender
     * @param InvoiceSender $invoiceSender
     */
    public function __construct(
        SubjectReader $subjectReader,
        HandlerInterface $handler,
        ConfigInterface $config,
        OrderRepositoryInterface $orderRepository,
        OrderSender $orderSender,
        InvoiceSender $invoiceSender,
        Transaction $transaction,
        InvoiceService $invoiceService,
        \Magento\Eav\Api\AttributeSetRepositoryInterface $attributeSet
    ) {
        $this->subjectReader = $subjectReader;
        $this->handler = $handler;
        $this->config = $config;
        $this->orderRepository = $orderRepository;
        $this->orderSender = $orderSender;
        $this->invoiceSender = $invoiceSender;
        $this->attributeSet = $attributeSet;
        $this->invoiceService = $invoiceService;
        $this->transaction = $transaction;
        /*parent::__construct(
            $subjectReader,
            $handler,
            $config,
            $orderRepository,
            $orderSender,
            $invoiceSender);*/
    }

    public function execute(array $commandSubject)
    {
        $paymentDO = $this->subjectReader->readPayment($commandSubject);

        /** @var \Magento\Sales\Model\Order\Payment $payment */
        $payment = $paymentDO->getPayment();
        ContextHelper::assertOrderPayment($payment);

        $order = $payment->getOrder();
        $methodInstance = $payment->getMethodInstance();
        $methodInstance->setStore($order->getStoreId());

        $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
        $logger = $objectManager->create('\Psr\Log\LoggerInterface');

        $amount = $this->subjectReader->readAmount($commandSubject);
        $response = $this->subjectReader->readResponseObject($commandSubject);

        $this->handler->handle(
            $commandSubject,
            [
                'response' => ['object' => $response]
            ]
        );

        if ($methodInstance->getConfigPaymentAction() == PaymentAction::ACTION_AUTHORIZE_CAPTURE
            || $order->getIsVirtual()) {

            $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() ." is Virtual - capturing");

            $payment->capture();
            $this->orderRepository->save($order);

            $invoice = $payment->getCreatedInvoice();
            $logger->info("Xtreme_CaptureStrategyCommand: order is Virtual - invoice created, id: ", ['invoiceId' => $invoice->getId()]);
            if (!$order->getIsInProcess()
                && $invoice
                && $this->config->canSendInvoiceNotification($order->getStoreId())
            ) {
                $logger->info("Xtreme_CaptureStrategyCommand: order is Virtual - sending invoice email");
                $this->invoiceSender->send($invoice);
            }
        } else {
            $payment->registerAuthorizationNotification($amount);
            $order->setState(\Magento\Sales\Model\Order::STATE_NEW)->setStatus('pending_payu_paid');
            //$history = $order->addStatusHistoryComment('Order is : '.$orderLabel, $order->getStatus());
            //$history->setIsCustomerNotified(true);
            //$history->save(); 
            $this->orderRepository->save($order);

            $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() . " is NOT Virtual - creating partial invoice");

            if(!$order->getIsVirtual())
            {
                $createinvoice = $order->canInvoice();
                if ($createinvoice)
                {
                    $itemsArray  = array();
                    $subTotal = 0;
                    foreach($order->getAllItems() as $orderitem)
                    {
                        $product = $orderitem->getProduct();
                        $attributeSetName = $this->getAttributeSetName($product);
                        if( in_array($attributeSetName, ['eBook', 'Audiobook MP3', 'eBook Free']) )
                        {
                            if($orderitem->getQtyToInvoice() > 0)
                            {
                                $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() . " is NOT Virtual - adding item to invoiceArray, item id: " . $orderitem->getId());

                                $id = $orderitem->getId();
                                $itemsArray[$id] = $orderitem->getQtyToInvoice();
                                $subTotal += $orderitem->getRowTotalInclTax();
                            }
                        }
                        else
                        {
                            $logger->info("Xtreme_CaptureStrategyCommand: order " . $orderitem->getId() . ", " . $orderitem->getSku() . " attributeSet: " . $attributeSetName . " - not added to invoice");
                        }
                    }
                    if(count($itemsArray)>0)
                    {
                        $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() . " is NOT Virtual - creating invoice");

                        $shippingAmount = '0.00';
                        $subTotal = $subTotal;
                        $baseSubtotal = $subTotal;
                        $grandTotal = $subTotal;
                        $baseGrandTotal = $subTotal;
                        $invoice = $this->invoiceService->prepareInvoice($order, $itemsArray);
                        $invoice->setShippingAmount($shippingAmount);
                        $invoice->setSubtotal($subTotal);
                        $invoice->setBaseSubtotal($baseSubtotal);
                        $invoice->setGrandTotal($grandTotal);
                        $invoice->setBaseGrandTotal($baseGrandTotal);
                        $invoice->register();
                        $invoice->save();

                        $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() . " is NOT Virtual - saving transaction");

                        $transactionSave = $this->transaction->addObject(
                            $invoice
                        )->addObject(
                            $invoice->getOrder()
                        );
                        $transactionSave->save();

                        $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() . " is NOT Virtual - sending email to customer");

                        $this->invoiceSender->send($invoice);
                        $order->setTotalPaid($grandTotal);
                        $order->setBaseTotalPaid($grandTotal);
                        $this->orderRepository->save($order);
                        $logger->info("Xtreme_CaptureStrategyCommand: order " . $order->getId() . " totalPaid: " . $grandTotal . ", subTotal: " . $subTotal);

                        //Send Invoice mail to customer
                        $order->addStatusHistoryComment(
                            __('Notified customer about invoice creation #%1.', $invoice->getId())
                        )
                            ->setIsCustomerNotified(true)
                            ->save();

                        $invoice->setState(2)->save();
                    }
                    else
                    {
                        $logger->info("Xtreme_CaptureStrategyCommand: order is NOT Virtual - no items in invoice, invoice not created " . $order->getId());
                    }

                }else{
                    return $this;
                }

            }
        }

        if (!$order->getEmailSent()) {
            $this->orderSender->send($order);
        }
    }

    //Build method to get attribute set
    public function getAttributeSetName($product) {

        $attributeSetRepository = $this->attributeSet->get($product->getAttributeSetId());
        return $attributeSetRepository->getAttributeSetName();
    }
}

[xtremevision]

Ok, I think I found the bug/fix.

use

$order->getAllVisibleItems()

instead

and uncomment these lines:

$order->setTotalPaid($grandTotal);
$order->setBaseTotalPaid($grandTotal);
$this->orderRepository->save($order);

Thank you.

[engcom-Delta]

Hi @xtremevision ,

As we are not able to replicate in default 2.4-develop instance, Can you please provide detail steps to reproduce the issue.

Thanks.

[engcom-Delta]

Hi @xtremevision ,

We have noticed that this issue has not been updated since long time. Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.