Magento2.4.7 Graphql products aggregation error

lano-vargas commented 2 months ago

Preconditions and environment

Magento version: 2.4.7
Anything else that would help a developer reproduce the bug

Steps to reproduce

{
  products(filter: {color: {eq: "52"}}, sort: {name: DESC}) {
    aggregations {
      attribute_code
      count
      label
      options {
        label
        value
        count
      }
    }
    items {
      name
      sku
      price_range {
        minimum_price {
          regular_price {
            value
            currency
          }
        }
      }
    }
    page_info {
      page_size
    }
  }
}

Expected result

Not to return error:

"path": [
                "products",
                "aggregations"
            ]

aggregations to return data but it's null

Actual result

{
    "errors": [
        {
            "message": "Internal server error",
            "locations": [
                {
                    "line": 3,
                    "column": 5
                }
            ],
            "path": [
                "products",
                "aggregations"
            ]
        }
    ],
    "data": {
        "products": {
            "aggregations": null,
            "items": [
                {
                    "name": "Tie Gift",
                    "sku": "I03966",
                    "price_range": {......

Additional information

Upon checking exception log:

GraphQL (3:5)
2:   products(filter: {brand: {eq: "409"}}, sort: {name: DESC}) {
3:     aggregations {
       ^
4:       attribute_code
 {"exception":"[object] (GraphQL\\Error\\Error(code: 0): Warning: Undefined array key \"attribute_type\" in /var/www/vhosts/test.com/htdocs/vendor/magento/module-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php on line 100 at /var/www/vhosts/test.com/htdocs/vendor/webonyx/graphql-php/src/Error/Error.php:170)
[previous exception] [object] (Exception(code: 0): Warning: Undefined array key \"attribute_type\" in /var/www/vhosts/test.com/htdocs/vendor/magento/module-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php on line 100 at /var/www/vhosts/test.com/htdocs/vendor/magento/framework/App/ErrorHandler.php:62)"} []test.com

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 months ago

Hi @lano-vargas. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

lano-vargas commented 2 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 months ago

Hi @lano-vargas. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 months ago

Hi @lano-vargas, here is your Magento Instance: https://75e4640aa749e38caecb37dbbf0ae9ef.instances-prod.magento-community.engineering Admin access: https://75e4640aa749e38caecb37dbbf0ae9ef.instances-prod.magento-community.engineering/admin_e513 Login: 20061308 Password: e9e9ba250872

lano-vargas commented 2 months ago

What is this version Magento ver. dev-develop. The issue is replicable on 2.4.7 can you give version 2.4.7 ? The issue might be fixed on your dev-develop version

lano-vargas commented 2 months ago

@magento give me 2.4.7 instance

m2-assistant[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 2 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://75e4640aa749e38caecb37dbbf0ae9ef.instances-prod.magento-community.engineering Admin access: https://75e4640aa749e38caecb37dbbf0ae9ef.instances-prod.magento-community.engineering/admin_ba1b Login: 6e3b3aaf Password: 2793e56bf25e

engcom-Bravo commented 2 months ago

Hi @lano-vargas,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

We are not getting any aggregation error.It might be possible issue got fixed in Latest 2.4-develop instance.

Thanks.

lano-vargas commented 2 months ago

Something weird going on here. It's a specific scenario issue here, I'm not entirely sure how to completely replicate this but I have done is mess about the attribute+options creation/deletion and products attribute options assignment creation/deletion

It appears that when an attribute option is deleted but there are still products assigned to it the graphl returns some extra array of object which appear to be the product that were assigned to previous attribute that was deleted.

It return the attribute id on both field e.g:

{
       "count": 1,
       "label": "417",
        "value": "417",
        "__typename": "AggregationOption"
}

in Label it should return a string name such as colour etc...

engcom-Bravo commented 2 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 2 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://75e4640aa749e38caecb37dbbf0ae9ef.instances-prod.magento-community.engineering Admin access: https://75e4640aa749e38caecb37dbbf0ae9ef.instances-prod.magento-community.engineering/admin_3a6b Login: 1a20dbae Password: 05c5bb00b9f1

engcom-Bravo commented 2 months ago

Hi @lano-vargas,

Thanks for your update.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

We have created attribute and assigned to some of the products and after that deleted that attribute.

There was no error.We are getting aggregations.

Hence we are closing this issue.

Thanks.

hnsr commented 3 weeks ago

Just wanted to chime in and let you now that I am also observing this exact same error on a 2.4.7 instance. Will try and see if I can help with the reproduction.

hnsr commented 3 weeks ago

Looks like this error was happening due to certain products having non-existent option ID references for the color attribute. This was probably the result of a botched data migration in our clients project.

raoulguillermo commented 1 week ago

I have(had) the same issue. Fixed it by changing the code.

/vendor/magento/module-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php line 100

public function build(AggregationInterface $aggregation, ?int $storeId): array
{
    $attributeOptions = $this->getAttributeOptions($aggregation, $storeId);
    $result = [];
    foreach ($this->getAttributeBuckets($aggregation) as $bucket) {
        $bucketName = $bucket->getName();
        $attributeCode = \preg_replace('~_bucket$~', '', $bucketName);
        $attribute = $attributeOptions[$attributeCode] ?? [];

        $result[$bucketName] = $this->layerFormatter->buildLayer(
            $attribute['attribute_label'] ?? $bucketName,
            \count($bucket->getValues()),
            $attribute['attribute_code'] ?? $bucketName,
            isset($attribute['position']) ? $attribute['position'] : null
        );

        $options = $this->getSortedOptions($bucket, isset($attribute['options']) ? $attribute['options'] : []);
        foreach ($options as $option) {
            $result[$bucketName]['options'][] = $this->layerFormatter->buildItem(
                $option['label'],
                $option['value'],
                $option['count']
            );
        }
    }

    return $result;
}

I don't think this is the way to go. But works for now

magento / magento2