magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.46k stars 9.29k forks source link

Widget category tree is not rendered correctly #39008

Open sheepfy opened 1 month ago

sheepfy commented 1 month ago

Preconditions and environment

If you have deeper category levels, like till level 5 or 6, if you open an widget, place the widget on Anchor Categories, specific categories, the category tree in there, will not render more than 3 level due to incorrect handleOpenNode function.

This fix is a copy paste from the working handleOpenNode function from there: vendor/magento/module-catalog/view/adminhtml/templates/catalog/category/tree.phtml

Example tree before the fix: image

Example tree after the fix: image

Issue fixed by this PR https://github.com/magento/magento2/pull/39007

Steps to reproduce

On vanila magento with sampledata, create 2 more categories under Woman -> Tops -> Jackets Go to widgets -> pick one or create one -> select Anchor Categories -> Specific categories -> Open category tree

Expected result

Have all the categories available in the tree

Actual result

Tree is not fully rendered

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 month ago

Hi @sheepfy. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 month ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 1 month ago

Hi @sheepfy,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

Widgets-New-Widget-Elements-Content-Magento-Admin

Tree is not fully rendered

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 1 month ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12692 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 month ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Bravo commented 2 weeks ago

Hi @sheepfy,

Internal team has started to work on it

Thanks.