Magento\Framework\MessageQueue\PublisherInterface::publish() should never (ever) be called from code which is inside of active DB transaction

[pczerkas]

Preconditions and environment

• Magento version: any version

Steps to reproduce

If queue message is published inside of open DB transaction, and message consumer processes it faster then DB transaction is commited, then message consumer (which is separate process from publisher) has not consistent view on data in DB, which leads to bugs.

Expected result

Queue messages can only be published, if calling code is NOT inside of active DB transaction.

Actual result

Queue messages ARE published, when calling code IS inside of active DB transaction.

Example: https://github.com/magento/magento2/blob/6f4805f82bb7511f72935daa493d48ebda3d9039/app/code/Magento/AsynchronousOperations/Model/BulkManagement.php#L131

            $this->entityManager->save($bulkSummary);

            $this->publishOperations($operations);

            $connection->commit();

Additional information

Problem can be resolved (in ideal scenario) by adding before plugin on interface Magento\Framework\MessageQueue\PublisherInterface::publish(), which checks if getTransactionLevel() on any active DB connection is not greater than 0.

This would probably be backward-incompatible change.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @pczerkas. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @pczerkas,

Thank you for the report and collaboration!

Can you let us know in which module or while calling which consumer this issue has occured.

[pczerkas]

Can you let us know in which module or while calling which consumer this issue has occured.

Hi @engcom-November , this issue is about general design here.

We've seen that problem happening in consumer async.operations.all - sometimes first operation in bulk is not marked as done in DB.

[pczerkas]

@engcom-November , please look at https://github.com/magento/magento2/pull/39057 where is proposed fix. Looks like tests are passing OK.

[m2-assistant[bot]]

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @pczerkas,

Thank you for the report and your collaboration!

Your description seems valid to us. However, could you please provide details of the real-world scenario in which the flow is failing? We will try to replicate the scenario on our end to see if the issue is reproducible.

Thanks

[engcom-Hotel]

Hello @pczerkas,

This issue is being closed since it has not been updated in a long time. Please feel free to reopen or raise a new ticket if the issue still exists.

Thanks