Product stock status change does not purge product varnish cache

[zakdma]

Preconditions and environment

• Magento version is the latest 2.4.7-p2
• Varnish is used as FPC
• Indexers are in UPDATE BY SCHEDULE mode
• Cron is running

Steps to reproduce

1. Logon into admin panel
2. Go to Stores>Configuration>Catalog>Inventory. Open the Stock Options dropdown. Set Yes in the Display Out of Stock Products option
3. Create a simple product with a stock quantity (id = 1, SKU = simple1)
4. Please note: Varnish cache should be enabled
5. Go to System > Extensions > Integrations
6. Add new integration.
7. Below the General section enter Name, Email (optional), and Password.
8. In the left menu, click API.
9. From the Resource Access drop-down menu, select All.
10. Click Save
11. On the Integrations page, next to the newly created integration, click Activate.
12. On the Integration page, you can find the list of the resources, click Allow.
13. The Integration Token Details are generated.
14. Copy and save Access Token to use it further
15. Click Done.
16. Go to Stores > Configuration > Services > OAuth > Consumer Settings > Allow OAuth Access Tokens to be used as standalone Bearer tokens option to Yes. Save configuration.
17. Open the product on the front and see it's in stock
18. Use any REST client and run the request

    curl -X PUT "https://<magento-host>/rest/V1/products/simple1/stockItems/1" -H "Authorization: Bearer <access-token>" -H "Content-Type:application/json" --globoff -k --data-binary @- << EOF
    {
    "stock_item": {
    "qty": 55.0,
    "is_in_stock": false
    }
    }
    EOF

19. Refresh the front product page.

Expected result

Product became "Out of Stock" on the front page

Actual result

Product is still "In Stock" on the front page

Additional information

The problem is that Stock indexer does not reset FPC for product (tag: catp) when reindexed See stock indexer implementation https://github.com/magento/magento2/blame/2.4-develop/app/code/Magento/CatalogInventory/Model/Indexer/Stock.php#L84 and compare it with the Price indexer https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Model/Indexer/Product/Price.php#L96

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @zakdma. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[andrewbess]

Hello @zakdma Thank you for your contribution Great catch Could you please provide the fix Thank you in advance.

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @zakdma ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and the issue is reproducible. Kindly refer the screenshots.

Steps to Reproduce 1.Go to Stores>Configuration>Catalog>Inventory. Open the Stock Options dropdown. Set Yes in the Display Out of Stock Products option

2. Enable Varnish Cache
3. Create a simple product with a stock quantity (id = 1, SKU = simple1)
4. Go to System > Extensions > Integrations
5. Add new integration.
6. Below the General section enter Name, Email (optional), and Password.
7. In the left menu, click API.
8. From the Resource Access drop-down menu, select All.
9. Click Save
10. On the Integrations page, next to the newly created integration, click Activate.
11. On the Integration page, you can find the list of the resources, click Allow.
12. The Integration Token Details are generated.
13. Copy and save Access Token to use it further
14. Click Done. 15.Go to Stores > Configuration > Services > OAuth > Consumer Settings > Allow OAuth Access Tokens to be used as standalone Bearer tokens option to Yes. Save configuration. 16.Open the product on the front and see it's in stock
15. Use any REST client and run the request
16. Refresh the front product page. Observe product is still in stock.

Thanks.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12879 is successfully created for this GitHub issue.

[m2-assistant[bot]]

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.