magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.31k forks source link

Cart items with custom options always out of stock in PWA (GraphQl) #39065

Closed HalievDmitry closed 3 weeks ago

HalievDmitry commented 2 months ago

Preconditions and environment

Steps to reproduce

  1. create a new product with required custom option (any type) with 100 qty in stock.
  2. add this product with the selected custom option to the cart (just 1 item)
  3. go to cart page

Expected result

Cart item is in stock, you can adjust the qty and proceed to checkout.

Actual result

Cart item is out of stock and you need to remove it from your cart.

Additional information

In vendor/magento/module-inventory-graph-ql/Model/Resolver/StockStatusProvider.php:58 the $product->getSku() result passed to AreProductsSalableInterface. But the getSku() returns a combined cart item SKU (product sku + custom option sku, ex. product1-customoption1) instead of raw product SKU (ex. product1). Obviously we don't have a stock records for such combined SKUs. Looks like $product->getData('sku') might be used here. As a temporary fix I put a before plugin on AreProductsSalableInterface to "clear" the SKUs and avoid the similar bugs.

Release note

No response

Triage and priority

m2-assistant[bot] commented 2 months ago

Hi @HalievDmitry. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 2 months ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 1 month ago

Hi @HalievDmitry ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and issue is not reproducible . Kindly refer the screenshots.

Steps to Reproduce :

  1. Install latest 2.4-develop instance.
  2. create a new product with required custom option (any type) with 100 qty in stock.
  3. add this product with the selected custom option to the cart (just 1 item) image
  4. go to cart page image
  5. Update the Qty - image image Observe user is able to update the Qty Please let us know if any other steps are needed to be performed.

Thanks.

engcom-Delta commented 3 weeks ago

Hi @HalievDmitry ,

We have noticed that this issue has not been updated since long time. Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.