Open sheepfy opened 1 month ago
Hi @sheepfy. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release@magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hi @sheepfy,
Thanks for your reporting and collaboration.
We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.
Having category rewrites + product rewrite
Hence Confirming the issue.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12801 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Preconditions and environment
The old version had this if statements:
if ($this->isCategoryRewritesEnabled()) {
https://github.com/magento/magento2/blob/2.4.6-p1/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php
Checking now the 2.4.7-p1 version, seems that the generation logic was moved into a separate method:
private function generateCategoryUrls(int $storeId, Product $product, ObjectRegistry $categories): array
But the IF statement was forgot to be added. (Also if checking the other category generation method "generateCategoryUrlsInStoreGroup", that one contains the IF statement)
https://github.com/magento/magento2/blob/2.4.7-p1/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php
Steps to reproduce
Set the admin config: catalog/seo/generate_category_product_rewrites to 0 (it should be by default set to 0) Save a product/create a product and then check the url rewrites
Note that in order to trigger the url generation, you need to have data changes on the product. For example, do change visibility from Catalog, Search to Catalog to trigger it
Expected result
Have only product rewrite
Actual result
Have category rewrites + product rewrite
Additional information
No response
Release note
No response
Triage and priority