magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.46k stars 9.28k forks source link

[Issue] Fix recipient and shipper address lines in fedex request #39072

Open m2-assistant[bot] opened 3 weeks ago

m2-assistant[bot] commented 3 weeks ago

This issue is automatically created based on existing pull request: magento/magento2#39043: Fix recipient and shipper address lines in fedex request


Description (*)

This PR adds fixes to the FedEx shipment request. According to FedEx Ship API: https://developer.fedex.com/api/en-us/catalog/ship/v1/docs.html#operation/Create%20Shipment the addresses accept street lines as an array. Passing it as an array of a single combined string may lead to an error from FedEx API because according to the documentation, Max Length is 35 of a string.

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Place an order with a FedEx shipping method
  2. Go to Admin Panel and find the order
  3. Ship the order and create a FedEx label

Questions or comments

None

Contribution checklist (*)

m2-assistant[bot] commented 3 weeks ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

m2-assistant[bot] commented 2 weeks ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 2 weeks ago

Hi @SerhiiMandrykin

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and it is working as per the documentation. Kindly refer the screenshots.

Steps to reproduce

  1. Place an order with less than 35 characters as shipping address and fedex shipping method.
  2. Create shipping label.
  3. Observe user should be able to create shipping label image
  4. Place another order with more than 35 characters as shipping address and fedex shipping method.
  5. Create shipping label.
  6. Observe user is unable to create shipping label and user receives error as shipping address is more than 35 characters. image

Please let us know if any other steps are needed to be performed.

Thanks.