`Magento_ServiceProxy` has an undefined hard dependency on `Magento_PaymentServicesDashboard`

fritzmg commented 2 months ago

Preconditions and environment

Magento version: 2.4.7-p2
Disabled Magento_PaymentServicesDashboard module

Steps to reproduce

Install Magento 2.4.7-p2
Disable Magento_PaymentServicesDashboard (and all modules that Magento says depend on it).
Access the back end

Expected result

The back end can be accessed.

Actual result

The following error occurs:

Exception #0 (LogicException): Could not create an acl object: Invalid Document 
Error in merged XML after reading vendor/magento/module-config/etc/acl.xml
Element 'resource': The attribute 'title' is required but missing.

Additional information

The problem is, that Magento_ServiceProxy actually depends on Magento_PaymentServicesDashboard because it references a <resource> in its etc/acl.xml that is actually defined by Magento_PaymentServicesDashboard:

<!-- vendor/magento/module-service-proxy/etc/acl.xml -->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Acl/etc/acl.xsd">
    <acl>
        <resources>
            <resource id="Magento_Backend::admin">
                <resource id="Magento_Sales::sales">
                    <resource id="Magento_Sales::sales_operation">
                        <resource id="Magento_PaymentServicesDashboard::paymentservices">
                            <resource id="Magento_ServiceProxy::services" title="Saas Services Proxy" translate="title" sortOrder="100"/>
                        </resource>
                    </resource>
                </resource>
            </resource>
        </resources>
    </acl>
</config>

The <resource id="Magento_PaymentServicesDashboard::paymentservices"> would be defined by Magento_PaymentServicesDashboard, but since the latter is disabled, the <resource> does not exist and the XML validation will then fail with the aforementioned error.

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 2 months ago

Hi @fritzmg. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release
For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 2 months ago

Hi @fritzmg,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

We are still able to access the backend.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

fritzmg commented 2 months ago

@engcom-Bravo I think you did not follow the reproduction steps exactly:

Disable Magento_PaymentServicesDashboard (and all modules that Magento says depend on it).

According to your screenshot you haven't disabled all modules that depend on Magento_PaymentServicesDashboard.

RichardOutram commented 4 weeks ago

This issue happened for me to.

engcom-Bravo commented 4 weeks ago

@RichardOutram Thanks for your contribution!!.

Hi @fritzmg,

Thanks for your update.

similar issue has been confirmed here https://github.com/magento/magento2/issues/38839.

Hence we are closing this as duplicate.

Thanks.

magento / magento2