Issue: Incorrect Data on Magento 2 Dashboard

[SerhiiMandrykin]

Preconditions and environment

• Magento version: 2.4.7
• Commit that caused the bug: https://github.com/magento/magento2/commit/dd769504d2a56e510b1632e8f1a5f42c9571af52
• Suggestion: rollback the commit

Steps to reproduce

1. Go to frontend.
2. Place 2 orders.
3. Change the creation date of the first order: -20h (in sales_order table)
4. Go to Magento 2 Dashboard

Expected result

Totals in the dashboard bar are calculated correctly

Actual result

Totals are not calculated correctly:

Workaround:

1. Switch to a different timeframe:
2. Switch back to 24h:
3. The totals are calculated correctly:

Additional information

This bug was caused by https://github.com/magento/magento2/commit/dd769504d2a56e510b1632e8f1a5f42c9571af52 and this line: $period = $this->getRequest()->getParam('period', $firstPeriod);

Setting $firstPeriod as a default value IS NOT correct because it would be today instead of 24h (see \Magento\Backend\Model\Dashboard\Period::getDatePeriods)

BUT by loading the dashboard there is no period parameter in the request so 24h is pre-selected:

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @SerhiiMandrykin. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[SerhiiMandrykin]

I prepared a fix in https://github.com/magento/magento2/pull/39138

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[devchris79]

Hi @SerhiiMandrykin does the fix work for the circumstances that were outlined in #36199 ?

[SerhiiMandrykin]

@devchris79 works well for me

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @SerhiiMandrykin ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and issue is not reproducible . Kindly refer the screenshots.

Steps to reproduce -

1. Go to frontend.
2. Place 2 orders.
3. Check the Dashboard before changing the creation date
4. Change the creation date of the first order: -20h (in sales_order table)
5. Go to Magento 2 Dashboard, observe data is displaying as expected

Please let us know if any other steps are needed to be performed. Thanks.