Open ShapesGraphicStudio opened 1 month ago
Hi @ShapesGraphicStudio. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release@magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hi @ShapesGraphicStudio,
Thanks for your reporting and collaboration.
We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.
Steps to reproduce
when we enable only International Priority Shipping Method no shipping method getting displayed.
Hence Confirming the issue.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12965 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
I can elaborate and expand upon this issue. It appears a number of international methods were left out of the Fedex module, particularly nearly all of the EU Domestic methods.
The Model\Carrier class needs to be updated to include these missing methods.
I've been able to work around the issue with the following plugin:
class AddFedexMethods
{
/**
* Add missing carrier methods to FedEx.
*
* @param \Magento\Fedex\Model\Carrier $subject
* @param callable $proceed
* @param string $type
* @param string $code
* @return \Magento\Framework\Phrase|array|false
*/
public function aroundGetCode(
\Magento\Fedex\Model\Carrier $subject,
callable $proceed, $type, $code = ''): \Magento\Framework\Phrase|array|false
{
$result = $proceed($type, $code);
if ($type == 'method') {
$codes = [
'method' => [
'FEDEX_FIRST' => __('First'),
'FEDEX_PRIORITY_EXPRESS' => __('Priority Express'),
'FEDEX_PRIORITY' => __('Priority'),
'FEDEX_PRIORITY_EXPRESS_FREIGHT' => __('Priority Express Freight'),
'FEDEX_PRIORITY_FREIGHT' => __('Priority Freight'),
'FEDEX_ECONOMY_SELECT' => __('Economy Select')
]
];
if ($code !== '' && $result === false) {
if (!isset($codes[$type][$code])) {
return false;
} else {
return $codes[$type][$code];
}
}
if ($code === '') {
return array_merge($codes[$type], $result);
}
}
return $result;
}
}
Preconditions and environment
Steps to reproduce
Expected result
International Priority Shipping Method Should be displayed to customer.
Actual result
No shipping method displayed.
Additional information
With the help of FedEx devs, regarding the International Priority Shipping Method, I tried to change all 'INTERNATIONAL_PRIORITY' entries to 'FEDEX_INTERNATIONAL_PRIORITY' directly in vendor/magento/module-fedex/Model/Carrier.php, get back to admin config to reselect International Priority and it seems to do the job.
FedEx devs say there is also another method missing : ''FEDEX_INTERNATIONAL_PRIORITY_EXPRESS'
Release note
No response
Triage and priority