magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

[Issue] [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig #39165

Open m2-assistant[bot] opened 2 months ago

m2-assistant[bot] commented 2 months ago

This issue is automatically created based on existing pull request: magento/magento2#39163: [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig


Description (*)

This PR add paypal_express_visible_on_cart and paypal_express_active in graphQl StoreConfig type.

:+1: I think, is important to prefix configuration by theme (ie: paypal) - So payment_payflowpro_cc_vault_active must be replaced by paypal_payment_payflowpro_cc_vault_active ...

query StoreConfig {
  storeConfig {
    paypal_express_active
    paypal_express_visible_on_cart
  }
}

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PayPal and execute following graphql query :

query StoreConfig {
  storeConfig {
    paypal_express_active
    paypal_express_visible_on_cart
  }
}

Contribution checklist (*)

m2-assistant[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 2 months ago

Hi @dimitriBouteille,

Thanks for your reporting and collaboration.

We have verified and it seems to be an improvement.Hence we are considering this as Feature Request.

Thanks.