magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

Unicode character breaks email template editor #39176

Open zakdma opened 2 months ago

zakdma commented 2 months ago

Preconditions and environment

Steps to reproduce

  1. Go to admin area.
  2. Open Marketing/Communications/Email Templates list
  3. Click Add New Template button on the top-right corner
  4. See email template editor opened
  5. Select Magento_Sales/New Order template as a value for Template form field
  6. Click Load Template button
  7. Enter any name to Template Name field
  8. Add unicode symbol U+1F447 (👇) at any place in Template Content editor. Screenshot: https://prnt.sc/bDnJ5BzxSQTM
  9. Click Save Template button to save template
  10. Open the saved template again to edit

Expected result

Template Content field contains all template text as saved previously

Actual result

Template Content field contains text only prior to the inserted unicode character 👇 All further text is truncated Screenshot: https://prnt.sc/zF5HOkJokwDj

Additional information

No response

Release note

No response

Triage and priority

m2-assistant[bot] commented 2 months ago

Hi @zakdma. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 2 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 2 months ago

Hi @zakdma,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-09-18 at 15 08 38

Template Content field contains text only prior to the inserted unicode character 👇 All further text is truncated.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 2 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13040 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

hostep commented 2 months ago

Would https://github.com/magento/magento2/pull/35174 fix this?

zakdma commented 1 month ago

@magento give me 2.4-develop instance

zakdma commented 1 month ago

Would #35174 fix this?

I don't think so. I tried manually changing the collation for the table and its fields, but it still doesn't work. It stopped trimming strings by such symbols but replaced them with ???? instead.