Checkbox selection bug in product inventory source assignment: multiple checkboxes selected unexpectedly

[edvardsr]

Preconditions and environment

• Magento version: 2.4.7-p2, tested on both community and enterprise editions
• PHP 8.3

For testing purposes, 7 inventory sources were added manually, making the total amount of sources be 8:

Each of them had identical settings:

Steps to reproduce

• Create a new product. For example, have the name and SKU be "test_1" and price set to $1. Assign the first two sources to the product and save it.

This is the source assignment that is expected after saving:

• Click "Assign Sources"
• Check any three checkboxes. The result will be as expected - 3 checked checkboxes.

• Check one more checkbox - pick any of the remaining checkboxes.

Expected result

4 checkboxes should be checked after checking the 4th checkbox.

Actual result

All checkboxes are checked. This is the issue.

This issue forces users to employ the workaround of unchecking the newly checked checkboxes.

If all the three newly checkboxes are unchecked afterwards and a fourth one is to be checked again, the issue no longer occurs. However, the issue does occur again if the user clicks "Cancel" and re-opens the "Assign Sources" dialog.

Additional information

No console errors or warnings appear while reproducing this issue.

Screenshots are from Magento 2.4.7-p2 community edition installed with composer with no customizations or additional modules.

The root of the issue appears to be that already selected sources are passed to the "selected" observable in multiselect.js, leading to the wrong assumption 6 records are selected instead of 4 after the 4th checkbox is checked, leading to a selectAll call in the updateState function.

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @edvardsr. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.