magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

FedEx team blocking our shippings because of wrong imageType #39186

Closed ShapesGraphicStudio closed 3 weeks ago

ShapesGraphicStudio commented 1 month ago

Preconditions and environment

Steps to reproduce

  1. Navigate through backend
  2. Generate FedEx shipping label

Expected result

Compliant shipping label for FedEx services.

Actual result

Blocked shipping by FedEx because of non compliant label.

Additional information

FedEx team told me I had to change imageType from PNG to PDF in vendor/magento/module-fedex/Model/Carrier.phpvendor/magento/module-fedex/Model/Carrier.php (around line 1240).

'labelSpecification' => [ 'labelFormatType' => 'COMMON2D', 'imageType' => 'PDF', 'labelStockType' => 'PAPER_85X11_TOP_HALF_LABEL', ],

Should this option not be administrable in back office?

This is already the third change asked by FedEx devs I have to make in this file (issues #39159 & #39162)

Release note

No response

Triage and priority

m2-assistant[bot] commented 1 month ago

Hi @ShapesGraphicStudio. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

m2-assistant[bot] commented 1 month ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 1 month ago

Hi @ShapesGraphicStudio,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.we are able to create the shipping label.

ShippingLabel(000000003) (1).pdf

Could you please elaborate the steps to reproduce to proceed further and let us know if we are missing anything.

Thanks.

ShapesGraphicStudio commented 1 month ago

Hello, This is not a bug blocking the generation of the label itself. The label is created but it has the wrong imageType regarding to what FedEx teams are telling us to validate our shippings.

FedEx team (commercial and dev) told me I had to change imageType from PNG to PDF for our shippings not to be blocked.

engcom-Bravo commented 3 weeks ago

Hi @ShapesGraphicStudio,

As per this comment https://github.com/magento/magento2/issues/39186#issuecomment-2404251209 we are closing this issue.

Thanks.

ShapesGraphicStudio commented 3 weeks ago

Hello @engcom-Bravo , I don't understand this issue closing as I need to change the module to make it work right following conversations with FedEx devs. The FedEX module as written in Magento Core can not retrieve the prices we dealed with them. So I think it does not fully work.

WITHOUT THIS WORKAROUND FEDEX TEAM TELL ME THEY WILL NOT PROCEED TO SHIP OUR PACKAGES.

Fixing this issue should have been as easy as providing an option in admin to be able to choose PNG or PDF for imageType.