magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

[Issue] add isMultipleFiles property to image form element template #39219

Open m2-assistant[bot] opened 2 months ago

m2-assistant[bot] commented 2 months ago

This issue is automatically created based on existing pull request: magento/magento2#36325: add isMultipleFiles property to image form element template


Prevent the "Browse to find or drag image here" button to disappear when an image is added in a multiple files image form element.

Description (*)

The only modification in the code is the addition of the already existing (and utilized) property "isMultipleFiles" into the condition that determine whether the "Browse to find or drag image here" button should be display or not.

In doing so, when the user add an image to the multiple files image form element, the "Browse to find or drag image here" is still there.

This is useful to inform the user that the form element can take multiple images and that these images can be drag and drop, especially when the form element is initially populated with existing images.

Manual testing scenarios (*)

  1. Create an adminhtml UI form with an imageUploader element.
  2. Define the "isMultipleFiles" boolean property to true in this element.
  3. Check the form, the "Browse to find or drag image here" button disappear after the first image is uploaded.

Contribution checklist (*)

m2-assistant[bot] commented 2 months ago

Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-November commented 2 months ago

Hello @pacco-a,

Thank you for report and collaboration!

Verified the issue on 2.4-develop. Not able to see div block Browse to find or drag image after image is uploaded. Please find the module used to reproduce the issue. P36325V.zip

Thank you.

github-jira-sync-bot commented 2 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13149 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 months ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.