Creating a category via import corrupts catalog - category view in admin when catagory contains "\" backslash character

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.52k stars 9.31k forks source link

Creating a category via import corrupts catalog - category view in admin when catagory contains "\" backslash character #39220

Closed fabotha closed 1 week ago

fabotha commented 3 weeks ago

Preconditions and environment

Magento version 2.4.7
Anything else that would help a developer reproduce the bug

Steps to reproduce

import a product with add/update 2 columns sku and categories 1122 in column 1 Home/More Items/More Items\Manuals in column 2 check data import import works ok Please note I got the category name wrong and did not mean to do this Please note the slash between More Items and Manuals is a backslash "\"

Expected result

Expected result is that a new category is created in home called "Home/More Items/More Items\Manuals" I coded the wrong dash I meant to create a new category in Home/More Items called Manuals but it created a new category called "Home/More Items/More Items\Manuals" in the home category. This new category displayed ok on the store front, but caused a corruption in the M2 Admin catalog - categories screen, so that no categories are displayed.

Actual result

The result I got was a new category "Home/More Items/More Items\Manuals" in the home category However in M2 , the catalog - categories admin screen now shows no categories and no structure, Images below

Additional information

See images https://firesupportltd-my.sharepoint.com/:f:/g/personal/accounts_firesupport_uk/EmdNw1PMzhFNg_03qrFohG8BZwp5PSflGf76ea34mqcEHg?e=R4EGm7

Release note

backslash character "\" not allowed in a catagory name and fails the check data stage with an error message.

Triage and priority

[X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 weeks ago

Hi @fabotha. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

fabotha commented 3 weeks ago

my release note should have said backslash character "\" not allowed in a category name and fails the check data stage with an error message.

m2-assistant[bot] commented 3 weeks ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 2 weeks ago

Hi @fabotha,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

The Categories are displaying correctly in admin side.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

fabotha commented 2 weeks ago

Hi Did you created the folder manually or using an import of a product? I had the problem when importing a csv file.

Please confirm

Thanks Frank

Please note we have a new email address @.**@.>

We ship Airsoft products all over the world. Tax free (20% off) at checkout to all countries.

Marui recoil Specials - repairs, upgrade, lipo conversion and custom work

Latest products - www.fire-support.co.uk/latest_products.phphttp://www.fire-support.co.uk/latest_products.php

OPEN 4 Days a week, Tue - friday 9am - 5.30pm Alternate Saturdays 10-5 see https://www.fire-support.co.uk/openingtimes.php Please always reply with our email in yours so we can track the conversation.

Frank - Director Tel 01733 247171

From: Venkata Kumar Kuntumalla @.> Sent: 08 October 2024 06:25 To: magento/magento2 @.> Cc: fabotha @.>; Mention @.> Subject: Re: [magento/magento2] Creating a category via import corrupts catalog - category view in admin when catagory contains "\" backslash character (Issue #39220)

Hi @fabothahttps://github.com/fabotha,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots. Screenshot.2024-10-08.at.10.43.52.png (view on web)https://github.com/user-attachments/assets/1998cc94-bbf3-4491-a666-16777d6e3786 Screenshot.2024-10-08.at.10.44.10.png (view on web)https://github.com/user-attachments/assets/1242c32e-c1cf-4afb-b43d-533df6fc00d0

The Categories are displaying correctly in admin side.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/magento/magento2/issues/39220#issuecomment-2398867217, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJKFLBRFHH7W4Q3QOMA42BDZ2NUEDAVCNFSM6AAAAABO4RZKCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYHA3DOMRRG4. You are receiving this because you were mentioned.Message ID: @.**@.>>

engcom-Bravo commented 1 week ago

Hi @fabotha,

Thanks for your update.

We have verified while importing the CSV file for a product.

Here is the CSV file :

export_catalog_product_20240918_032635.csv

Thanks.

fabotha commented 1 week ago

Hi Thank you for your reply. This broke my admin catalog / category screen display but I accept your results. We are on 2.4.7 p1 magento

Is it possible that an extension would have cause the issue? It displayed ok on the customer storefront display, just broke admin.

Thanks Frank

Please note we have a new email address @.**@.>

We ship Airsoft products all over the world. Tax free (20% off) at checkout to all countries.

Marui recoil Specials - repairs, upgrade, lipo conversion and custom work

Latest products - www.fire-support.co.uk/latest_products.phphttp://www.fire-support.co.uk/latest_products.php

Frank - Director Tel 01733 247171

From: Venkata Kumar Kuntumalla @.> Sent: 09 October 2024 08:57 To: magento/magento2 @.> Cc: fabotha @.>; Mention @.> Subject: Re: [magento/magento2] Creating a category via import corrupts catalog - category view in admin when catagory contains "\" backslash character (Issue #39220)

Hi @fabothahttps://github.com/fabotha,

Thanks for your update.

We have verified while importing the CSV file for a product.

Here is the CSV file :

export_catalog_product_20240918_032635.csvhttps://github.com/user-attachments/files/17304494/export_catalog_product_20240918_032635.csv

Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/magento/magento2/issues/39220#issuecomment-2401609664, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJKFLBSFJF425TZKRJHJWLDZ2TOVLAVCNFSM6AAAAABO4RZKCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGYYDSNRWGQ. You are receiving this because you were mentioned.Message ID: @.**@.>>

engcom-Bravo commented 1 week ago

Hi @fabotha,

Thanks for your update .

It might be possible any third party modules can causing this issue please check and let us know if you are facing any issue.

Thanks.

fabotha commented 1 week ago

Thank you. Frank

Please note we have a new email address @.**@.>

We ship Airsoft products all over the world. Tax free (20% off) at checkout to all countries.

Marui recoil Specials - repairs, upgrade, lipo conversion and custom work

Latest products - www.fire-support.co.uk/latest_products.phphttp://www.fire-support.co.uk/latest_products.php

Frank - Director Tel 01733 247171

From: Venkata Kumar Kuntumalla @.> Sent: 09 October 2024 10:38 To: magento/magento2 @.> Cc: fabotha @.>; Mention @.> Subject: Re: [magento/magento2] Creating a category via import corrupts catalog - category view in admin when catagory contains "\" backslash character (Issue #39220)

Hi @fabothahttps://github.com/fabotha,

Thanks for your update .

It might be possible any third party modules can causing this issue please check and let us know if you are facing any issue.

Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/magento/magento2/issues/39220#issuecomment-2401830754, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJKFLBSMUWVM5FTTMOKQFNDZ2T2PFAVCNFSM6AAAAABO4RZKCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRHAZTANZVGQ. You are receiving this because you were mentioned.Message ID: @.**@.>>

engcom-Bravo commented 1 week ago

Hi @fabotha,

Thanks for your update.

Since the issue is no more reproducible we are closing this issue Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

magento / magento2

Creating a category via import corrupts catalog - category view in admin when catagory contains "\" backslash character #39220

Preconditions and environment

Steps to reproduce

Expected result

Actual result

Additional information

Release note

Triage and priority

To learn more about issue processing workflow, refer to the Code Contributions.