search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.32k forks source link

[Issue] Ignore lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/en… #39304

Open m2-assistant[bot] opened 2 days ago

m2-assistant[bot] commented 2 days ago

This issue is automatically created based on existing pull request: magento/magento2#37631: Ignore lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/en…

…v.php that gets generated by running unit tests

Description (*)

When running Magento Framework unit tests on your local, one of the tests (don't ask me which one) generates a file: lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/env.php So I think we should ignore this file in git.

Related Pull Requests

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Clone this repo
  2. Check that your git status isn't dirty
  3. Run vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/
  4. When it's finished, check your git status again
  5. Expected is that it's still not dirty, but before this PR, it will show a new file found: lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/env.php

Questions or comments

In my opinion, it's not needed to run automatic tests on this PR, as it shouldn't affect anything besides local developer experience...

Contribution checklist (*)

github-jira-sync-bot commented 2 days ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13293 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 days ago

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.