Rate limiting not working

[devchris79]

Preconditions and environment

• Magento version 2.4.7-p2
• PHP 8.3

Steps to reproduce

Turn on rate limiting to reduce carding attack severity (Stores->Configuration->Sales->Sales->Rate limiting). Settings as below:

Expected result

When a guest attempts to place orders a 1 hour pause is put in place after 10 failed attempts, helping to reduce carding.

Actual result

I am seeing log entries saying that the rate limiting isn't working:

[2024-11-01T12:58:26.766321+00:00] main.ERROR: Backpressure sliding window not applied. Invalid request logger type: [] [] [2024-11-03T01:26:12.851250+00:00] main.ERROR: Backpressure sliding window not applied. Invalid request logger type: [] [] [2024-11-04T01:31:54.983504+00:00] main.ERROR: Backpressure sliding window not applied. Invalid request logger type: [] [] [2024-11-04T01:57:08.217718+00:00] main.ERROR: Backpressure sliding window not applied. Invalid request logger type: [] []

Additional information

I think the error is from by the line below : $requestLogger = $this->getRequestLogger();

In /vendor/magento/framework/App/Backpressure/SlidingWindow/SlidingWindowEnforcer. php:79

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [X] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @devchris79. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @devchris79,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and it looks like expected behaviour of magento. Could you please refer this document https://developer.adobe.com/commerce/webapi/get-started/rate-limiting/#log-contents.

Thanks.

[devchris79]

It would have been better if there was a note in the admin panel that Redis was required and/or a less trivial log entry.

Thanks anyway @engcom-Bravo, I will close this now.