magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

Invalid SKU Handling for Linked Products in Magento #39329

Open Syamsg opened 2 weeks ago

Syamsg commented 2 weeks ago

Preconditions and environment

Steps to reproduce

  1. Create a New Product:

    • Navigate to Catalog > Products.
    • Click on Add Product.
    • Fill in the necessary details, and in the SKU field, enter 0.
    • Save the product.
  2. Edit an Existing Product:

    • Go back to Catalog > Products.
    • Choose any existing product you wish to link the previously created product to.
    • Scroll down to the Linked Products section (Related Products, Up-Sells, or Cross-Sells).
  3. Add the Product with SKU "0":

    • In the linked products section, search for the product you created with the SKU of 0.
    • Add this product as a linked product.
  4. Save the Main Product:

    • Click on Save to save the changes made to the main product.
  5. Observe the Error:

    • After attempting to save, an error message will appear: "The linked product SKU is invalid. Verify the data and try again." image

image

Expected result

The system should allow the linking of the product with a SKU of "0" without throwing an error, or it should prevent saving a product with "0" as a SKU outright.

Actual result

The system throws an error stating that the linked product SKU is invalid, preventing any changes to the product.

Additional information

This issue arises in the file Magento\Catalog\Model\ProductLink\Repository, specifically in the public function save, where the following condition is used:

if (!$entity->getLinkedProductSku()) {
    throw new NoSuchEntityException(__('The linked product SKU is invalid. Verify the data and try again.'));
}

One approach to resolve this is by adding an explicit check for the SKU value to prevent saving it as "0." For instance, you could add a validation condition to prevent saving a SKU as "0" at the time of saving the product.

Release note

No response

Triage and priority

m2-assistant[bot] commented 2 weeks ago

Hi @Syamsg. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

m2-assistant[bot] commented 2 weeks ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 2 weeks ago

Hi @Syamsg,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Bundle-Products-Inventory-Catalog-Magento-Admin-11-06-2024_09_37_AM

The system throws an error stating that the linked product SKU is invalid, preventing any changes to the product.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 2 weeks ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13311 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 weeks ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.