No update must be a boolean, int given for bin/magent sampledata:deploy|remove --no-update

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

Open Software License 3.0

11.57k stars 9.32k forks source link

Description (*)

When adding or removing sample data you can tell the composer update command to not invoke the update command right away. Since newer versions type checking is set for this argument and it must be of type boolean instead of a integer.

Fixed Issues (if relevant)

Fixes magento/magento2#39344

Manual testing scenarios (*)

Install a clean Magento 2 installation
Try to deploy sample data without directly updating --no-update
A error was thrown, not anymore

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

Hi @JeroenBoersma. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. `Database Compare` 2. `Functional Tests CE` 3. `Functional Tests EE` 4. `Functional Tests B2B` 5. `Integration Tests` 6. `Magento Health Index` 7. `Sample Data Tests CE` 8. `Sample Data Tests EE` 9. `Sample Data Tests B2B` 10. `Static Tests` 11. `Unit Tests` 12. `WebAPI Tests` 13. `Semantic Version Checker`

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

magento / magento2