magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.57k stars 9.32k forks source link

Grouped Product Quantity Validation Displays Errors for All Inputs When One Input Is Invalid #39347

Open allforcode opened 2 weeks ago

allforcode commented 2 weeks ago

Preconditions and environment

Steps to reproduce

  1. Navigate to a grouped product page.
  2. Enter a negative value (e.g., -10) in one of the quantity input fields.
  3. Enter valid values (e.g., 6 or 9) in the other quantity input fields.
  4. Observe the error messages displayed.

Cursor_and_Set_of_Sprite_Yoga_Straps

Expected result

Only the input field with an invalid quantity should display an error message.

Actual result

All input fields display an error message, even if their values are valid.

Additional information

In Magento 2.4.5, the form validation is handled by view/frontend/web/product/view/validation.js, whereas in Magento 2.4.7, it is managed by lib/web/mage/validation.js.

Release note

No response

Triage and priority

m2-assistant[bot] commented 2 weeks ago

Hi @allforcode. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

m2-assistant[bot] commented 2 weeks ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 2 weeks ago

Hi @allforcode,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

Group-11-08-2024_09_48_AM

All input fields displays error message, even if their values are valid.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 2 weeks ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-13325 is successfully created for this GitHub issue.

m2-assistant[bot] commented 2 weeks ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Mohamed-Asar commented 6 days ago

@magento I'm working on this

phes71 commented 5 days ago

this will fix it https://github.com/magento/magento2/commit/95fd74f356652eb19274bf20815893649fafba72