CSV Product Import with NO stock changes assigns Products to default source

[lbajsarowicz]

Preconditions and environment

• Magento 2.4.6-p8

CSV file:

sku,custom_attribute
AD-1,attribute_value_first
AD-2,attribute_value_second

Steps to reproduce

Provided

1. I am logged as an Administrator with permission to update Prodcts and Inventories
2. There are two inventory sources: Default and Online Inventory
3. The products listed in CSV file exist and are assigned to Online Inventory

Steps

1. Navigate to System > Data Transfer > Import
2. Set Entity Type to Products, Import Behavior to Add / Update, select CSV file to import. (see Preconditions)
3. Perform Import

Expected result

The Products Inventory Source assignment should not change (should still be assigned to Online Inventory only.

Actual result

The Products get assigned to the Default Inventory Source.

Additional information

The problem lies in \Magento\CatalogImportExport\Model\Import\Product::_saveStockItem, which - regardless the Import CSV contains any Inventory changes or not - updates the Inventory.

However, instead of getting the current Inventory settings, it calls \Magento\CatalogImportExport\Model\Import\Product::getRowExistingStockItem, which - under the hood - creates a new inventory entry 🤯 with default Website ID and its Stock:

https://github.com/magento/magento2/blob/0b488dd1139e413cd5711241ae767030081805f6/app/code/Magento/CatalogImportExport/Model/Import/Product.php#L3435-L3440

Release note

No response

Triage and priority

• [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant[bot]]

Hi @lbajsarowicz. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this

• To learn more about issue processing workflow, refer to the Code Contributions.

  Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• [ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• [ ] 5. Add label Issue: Confirmed once verification is complete.
• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @lbajsarowicz,

Thanks for your reporting and collaboration. We have verified the issue in Latest 2.4-develop instance & 2.4.8-beta1 instance, but we are unable to reproduce the issue. Kindly refer the screenshots.

Steps to reproduce

1. Create two sources Default and Online Inventory
2. Create AD-1 and AD-2 Product and assign them to online inventory source
3. Import the csv prod.csv
4. After import navigate to catalog>products>AD-1 and AD-2 Products
5. Observe both products are assigned to online inventory and not assigned to default source.

Can you please re-verify and confirm if you are still facing the issue. Thanks.

[lbajsarowicz]

@magento give me 2.4-develop instance

[lbajsarowicz]

The problem no longer occurs in the latest (2.4.7) version of Magento. I'll find out what exact Commit fixed the issue and let you know in the thread.