Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
This issue is automatically created based on existing pull request: magento/magento2#39359: Correct colspan in visual swatch admin
Description (*)
The colspan is incorrect. Probably based on the text.phtml file, but there is only 1 th per store + 4 additional, as you can see in the code.
Manual testing scenarios (*)
Edit a visual swatch and look at the tfoot of the swatches table. The number does not match the number of columns if the number of storeviews is > 1 . For 1 storeview, the number still matches (1 * 2 + 3 = 5 and 1 + 4 = 5), but otherwise it will be too high.
(As far as I can tell, this doesn't have any effect because the number of stores is at least 1 so the colspan will always be high
Questions or comments
Contribution checklist (*)
[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)
This issue is automatically created based on existing pull request: magento/magento2#39359: Correct colspan in visual swatch admin
Description (*)
The colspan is incorrect. Probably based on the text.phtml file, but there is only 1
thper store + 4 additional, as you can see in the code.Manual testing scenarios (*)
Edit a visual swatch and look at the tfoot of the swatches table. The number does not match the number of columns if the number of storeviews is > 1 . For 1 storeview, the number still matches (1 * 2 + 3 = 5 and 1 + 4 = 5), but otherwise it will be too high.
(As far as I can tell, this doesn't have any effect because the number of stores is at least 1 so the colspan will always be high
Questions or comments
Contribution checklist (*)