[Issue] Removes some code for PHP versions we no longer support. - Githubissues

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.57k stars 9.32k forks source link

[Issue] Removes some code for PHP versions we no longer support. #39368

Closed m2-assistant[bot] closed 1 week ago

m2-assistant[bot] commented 1 week ago

This issue is automatically created based on existing pull request: magento/magento2#39202: Removes some code for PHP versions we no longer support.

Description (*)

Found some code in the codebase that no longer makes sense if we only support PHP 8.2 (soon 8.3?) and higher:

libxml_disable_entity_loader was deprecated in PHP 8.0: https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation
always_populate_raw_post_data was removed in PHP 7.0: https://www.php.net/manual/en/migration70.incompatible.php#migration70.incompatible.removed-ini-directives.features

Related Pull Requests

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Check that the changed classes still function like they should function

Questions or comments

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

Resolved issues:

[x] resolves magento/magento2#39361: Removes some code for PHP versions we no longer support.