mage.validation widget errorPlacement function not inside options so never gets loaded

phes71 commented 1 week ago

Preconditions and environment

2.4.7p-3
The issues is caused because of incorrect declaration of widget options in product/view/validation.js

errorPlacement function should be inside options.

Steps to reproduce

error on grouped product pages click add to cart without any options selected, and the validation error message is displayed on every option instead of inside div with id #validation-message-box

Expected result

validation error should be in div id #validation-message-box

Actual result

validation error shown in every grouped option qty

Additional information

fix by moving errorPlacement function inside options as below

$.widget('mage.validation', $.mage.validation, { options: { radioCheckboxClosest: 'ul, ol',

    /**
     * @param {*} error
     * @param {HTMLElement} element
     */
    errorPlacement: function (error, element) {
        var messageBox,
            dataValidate;

        if ($(element).hasClass('datetime-picker')) {
            element = $(element).parent();

            if (element.parent().find('.mage-error').length) {
                return;
            }
        }

        if (element.attr('data-errors-message-box')) {
            messageBox = $(element.attr('data-errors-message-box'));
            messageBox.html(error);

            return;
        }

        dataValidate = element.attr('data-validate');

        if (dataValidate && dataValidate.indexOf('validate-one-checkbox-required-by-name') > 0) {
            error.appendTo('#links-advice-container');
        } else if (element.is(':radio, :checkbox')) {
            element.closest(this.radioCheckboxClosest).after(error);
        } else {
            element.after(error);
        }
    }},

Release note

No response

Triage and priority

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 1 week ago

Hi @phes71. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

For more details, review the Magento Contributor Assistant documentation.
Add a comment to assign the issue: @magento I am working on this
To learn more about issue processing workflow, refer to the Code Contributions.

Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant[bot] commented 1 week ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

phes71 commented 1 week ago

this will fix it https://github.com/magento/magento2/commit/95fd74f356652eb19274bf20815893649fafba72

phes71 commented 1 week ago

Issue: Confirmed

engcom-Bravo commented 1 week ago

Hi @phes71,

Thanks for your reporting and collaboration.

Similar issue has been Confirmed here https://github.com/magento/magento2/issues/39347

Hence we are closing this as duplicate.

Thanks.

magento / magento2