Closed yssource closed 7 years ago
@yssource production mode does suppress errors and warnings. http://devdocs.magento.com/guides/v2.0/config-guide/bootstrap/magento-modes.html
We have created MAGETWO-53770 to investigate and fix the warning.
Is there any update on this issue?
@maksek Would be awesome to push it forward during hackathon.
Please, look at: 237e54d79c70d8954f16556a3a8195a8b7b6d942 7bed7ef0277a82552051c769afe054708c56bde7 397fa26f775ebe93c742fe3e4937d68571abf4b5
I'm closing this issue as we were not able to reproduce it on develop branch. If you can still reproduce this issue, please create a new GitHub issue report.
Does it mean that the next version of Magento 2.2 will be released from branch develop?
@tmotyl yes, 2.2.0 version will be created from branch 'develop'
Does it mean 2.1's issues will be ignored unless they exist on 2.2 as well?
@korostii , no, it does not. Bugs with high priority are being fixed and they are delivered in patch releases for 2.1.
Hi @NadiyaS, thanks for the timely response. I am sorry to continue bothering you, but i have couple of follow-up questions and @veloraven seems to mostly ignore me for whatever reason.
Is there a definition of "high priority" which I could look up somewhere? Does "security only" sound about right?
Since you seem to be representing Magento, I presume that you're saying that developers from Magento, Inc. won't be putting any resources into bugs they consider "low priority". But in this case there is a developer from the community is working on the backport: see PR #9718. Will such voluntary outside effort be denied from appearing on 2.1 branch, as well?
I mean, the issue clearly exists and there is someone working on it. I understand the reasoning behind not wanting to put any internal resources on it (and not creating a corresponding internal ticket \ having it on low priority or whatever), but why close the public GitHub issue altogether?
Hi, @korostii. Let me try to answer your questions.
2.1-develop
branch. The only difference to 2.1-develop
branch compared to develop
is higher requirements for backward compatibility. And, of course, all issues fixed in 2.1 should be fixed in 2.2 as well.develop-2.1
label. Any PR that follows code contibution requirements will be accepted.develop
branch (so for 2.2.0 release) and this was a reason to close this bug report. Back-port for 2.1-develop
branch (PR #9718) will be accepted as soon as all requirements for contribution are followed.Hi @vkublytskyi, thank you for the detailed response!
I am well aware of the points 1 and 2 you mention, and I do understand the reasoning behind them. However, if those policies are still in place, I do not fully understand why does it make sense to close an issue like this one.
Closing an acknowledged issue commonly means that the issue is resolved and there's no more work to be done (which is not true, if you do still allow the backporting step). I don't think there is a way to track resolved-on-develop-but-not-backported issues if they are being closed instaed of assigning an "up for grabs" label. Finally, there is this comment to the blog post about upvoting in which @maksek states, that:
In terms of upvoting on closed issues - at the moment we are not monitoring (or rarely monitoring such issues), due overload on opened issues.
And that, kind of, invalidates the whole point about upvoting if the issue is being closed.
We have open Pull Request for this issue. We should not close it. https://github.com/magento/magento2/pull/9718
Internal ticket to track issue progress: MAGETWO-70394
@okorshenko and now it can be closed or we should wait for the next 2.1.x
release? Would be nice if issue status transition rules are described somewhere.
we will close the issue once MAGETWO-70394 released. We will describe issue status transition rules after 2.2 release
My working environment looks like this. And I run magento with a fresh installer by composer create-project.
Fedora 23 kernal: 4.4.9-300.fc23.x86_64
It is reporting the following warnings, when I was debugging and found it was caused by