search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Braintree order email not displaying credit card type/number label #6568

Closed middlegrey closed 3 years ago

middlegrey commented 8 years ago

Upgraded from CE 2.0.7 to CE 2.1.1 using Composer

When orders are placed using Braintree Payments, the order email shows –

cc_type Visa cc_number xxxx-1234

Instead of –

Credit Card Type Visa Credit Card Number xxxx-1234

order-email

iivashchenko commented 8 years ago

Hi @middlegrey, thanks for the feedback, but we can't reproduce your issue as described. Could you please provide more detailed steps we must follow to reproduce this issue. If possible, identify the web server you are running, the versions of PHP and MySQL, logs would be helpful too.

middlegrey commented 8 years ago

Hi @iivashchenko, thanks for following up.

The server is running Apache 2.4.23 with PHP 5.6.25 and MySQL 5.6.31.

The steps to reproduce are the standard ones to purchase a product, albeit with a custom shipping module to calculate shipping cost.

Which logs would you like exactly?

iivashchenko commented 8 years ago

I've meant log files from /var/log folder within your root Magento installation. exception.log and system.log files may contain information concerning your issue.

middlegrey commented 8 years ago

I've checked the logs and there doesn't seem to be anything relevant. I also tried re-installing everything from scratch but the problem still remains.

Can you direct me to the module and/or methods responsible for generating the email payment details so I can try to track down the issue?

iivashchenko commented 8 years ago

Try to debug: app\code\Magento\Sales\Model\Order\Email\Sender\OrderSender::prepareTemplate The $transport['payment_html] variable must contain required template data.

antbates91 commented 7 years ago

I can confirm I'm also having this issue with Magento 2.1.2, PHP 7.0.7 and MySQL 5.6.

We originally had Magento 2.0.7 installed and upgraded to 2.1.0, then 2.1.2.

I've also noticed this same issue with PayPal too. The email renders payerEmail instead of the translation.

image

image

iivashchenko commented 7 years ago

We are closing this issue because it hasn’t been updated in more than two weeks. If you can still reproduce this issue, please create a new GitHub issue report.

antbates91 commented 7 years ago

@iivashchenko This issue is still present in 2.1.3

PHP 7.0.7 / 7.0.13 and MySQL 5.6.

Our upgrade path was Magento 2.0.7 -> 2.1.0 -> 2.1.2 -> 2.1.3.

image

iivashchenko commented 7 years ago

@antbates1991, thank you. We will try to reproduce it according to your upgrade path.

staffrob commented 7 years ago

Same issue here on 2.1.4 Upgrade path 2.1.1 -> 2.1.2 -> 2.1.3 -> 2.1.4 This is the least of our issues but just confirming

iivashchenko commented 7 years ago

@antbates1991, I've tested an upgrade circle of my Magento instance from 2.0.7 through 2.1.0, 2.1.2 to 2.1.3 with Braintree Payment configured. On every newly upgraded instance, I made one order via Braintree payment and didn't face a described issue.

My upgrade process includes the next steps:

composer require magento/product-community-edition 2.1.x --no-update composer update php bin/magento setup:upgrade php bin/magento setup:static-content:deploy php bin/magento indexer:reindex

Please, let me know if I missed something or what extra steps should I do to reproduce an issue. Thanks.

irevdev commented 7 years ago

Hi @iivashchenko

Having same issue on 2.1.5 CE

screen shot 2017-07-17 at 7 53 22 am

With locale options set to:

screen shot 2017-07-17 at 7 56 42 am

Theme has en_NZ translation file and all translations work fine on frontend.

Ran all of the above mentioned steps composer require magento/product-community-edition 2.1.5 --no-update composer update php bin/magento setup:upgrade php bin/magento setup:static-content:deploy php bin/magento indexer:reindex

But issue still remains.

Cheers

gboz17 commented 7 years ago

I'm having the same problem with 2.1.7.

It is showing up in the email and the customer account section.

iivashchenko commented 7 years ago

@irevdev, thank you for configuration settings which helped me to reproduce the bug. I've linked this GitHub issue to internal ticket MAGETWO-70958.

gboz17 commented 7 years ago

For some reason, Braintree's language file is not working (located in yourmagentoinstall/vendor/magento/module-braintree/i18n/en_US.csv

As a workaround, add the following to your language file:

"cc_type","Credit Card Type",module,Magento_Braintree "cc_number","Credit Card Number",module,Magento_Braintree "avsPostalCodeResponseCode","AVS Postal Code Response Code",module,Magento_Braintree "avsStreetAddressResponseCode","AVS Street Address Response Code",module,Magento_Braintree "cvvResponseCode","CVV Response Code",module,Magento_Braintree "processorAuthorizationCode","Processor Authorization Code",module,Magento_Braintree "processorResponseCode","Processor Response Code",module,Magento_Braintree "processorResponseText","Processor Response Text",module,Magento_Braintree "braintree", "Braintree",module,Magento_Braintree "liabilityShifted", "Liability Shifted",module,Magento_Braintree "liabilityShiftPossible", "Liability Shift Possible",module,Magento_Braintree "riskDataId", "Risk ID",module,Magento_Braintree "riskDataDecision", "Risk Decision",module,Magento_Braintree "paymentId", "Payment Id",module,Magento_Braintree "payerEmail", "Payer Email",module,Magento_Braintree "sale","Sale",module,Magento_Braintree "credit","Credit",module,Magento_Braintree "authorization_expired","Authorization expired",module,Magento_Braintree "authorizing","Authorizing",module,Magento_Braintree "authorized","Authorized",module,Magento_Braintree "gateway_rejected","Gateway rejected",module,Magento_Braintree "failed","Failed",module,Magento_Braintree "processor_declined","Processor declined",module,Magento_Braintree "settled","Settled",module,Magento_Braintree "settling","Settling",module,Magento_Braintree "submitted_for_settlement","Submitted for settlement",module,Magento_Braintree "voided","Voided",module,Magento_Braintree "unrecognized","Unrecognized",module,Magento_Braintree "settlement_declined","Settlement declined",module,Magento_Braintree "settlement_pending","Settlement pending",module,Magento_Braintree "settlement_confirmed","Settlement confirmed",module,Magento_Braintree "paypal_account","Paypal account",module,Magento_Braintree "coinbase_account","Coinbase account",module,Magento_Braintree "europe_bank_accout","Europe bank account",module,Magento_Braintree "credit_card","Credit card",module,Magento_Braintree "apple_pay_card","Apple pay card",module,Magento_Braintree "android_pay_card","Android pay card",module,Magento_Braintree

magento-engcom-team commented 7 years ago

@middlegrey, thank you for your report. We've created internal ticket(s) MAGETWO-70958 to track progress on the issue.

fireatwill commented 6 years ago

I'm seeing the same issue with 2.2.5, and 2.2.6, and with other payment modules. These are new installs, so in my case not upgrade path related.

Having the store locale (Configuration / General / Locale Options / Locale) set to anything other than English (United States) seems to cause this problem. In my case, I'm using English (United Kingdom). If I set the locale back to English (United States), the email text works properly.

It seems to be related to translation fallback - the payment module has i18n/en_US.csv with translations for cc_type etc., but because the locale is en_GB, not en_US, the fallback seems to be to use the original text string (in this case "cc_type" for example) instead of the en_US translation.

m2-assistant[bot] commented 5 years ago

Hi @gauravagarwal1001. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

m2-assistant[bot] commented 5 years ago

Hi @gulshanchitransh. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

gulshanchitransh commented 5 years ago

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @gulshanchitransh. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @gulshanchitransh, here is your Magento instance. Admin access: https://i-6568-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

sheshagiriAnvekar commented 4 years ago

Is this issue solved in 2.3.5 p1 ?

magento-engcom-team commented 3 years ago

The report related to technology or functionality that was removed(or not supported) from the Magento code-base. Or cannot be fixed and delivered in the scope of this public repository.

Examples: