magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Free Shipping stuck on checkout page when update qty on Checkout Cart page #6780

Closed Tapin1 closed 7 years ago

Tapin1 commented 8 years ago

"Free shipping" method still visible (available) when you change cart (below free shipping threshold) during checkout.

Preconditions

  1. Magento ver. 2.1.0
  2. PHP 7

    Steps to reproduce

1) set free shipping amount to $50 (or any value you like) 2) Go to your store and add to cart any 2 items total cost of ABOVE 50$ ($45+$45 for example) 3) Go to check out. Complete checkout form 4) You'll see free shipping method - it's OK 5) No Go back to your cart and remove one item (so you card gonna be below $50) 6) Go to checkout again 7) Free shipping is still there (You can't remove it ever!)

Expected result

  1. Free shipping method should be removed if cart price fall below free shipping amount after cart change

    Actual result

  2. 7) Free shipping is still there (You can't remove it ever!)
ErikPel commented 8 years ago

Also happening here.

Magento 2.1 and PHP 7

Those customers that do the steps described in the issue are getting free shipping forever until we remove then straight from the database to fix it.

Tapin1 commented 8 years ago

Any solution/fix?

SerhiyShkolyarenko commented 7 years ago

@Tapin1 thank you for reporting! Please clarify the details which way you set 50$ free shipping? @ErikPel please join the clarification.

Tapin1 commented 7 years ago

I have a "Free shipping" method set. The amount for free shipping is >=$50 If you update your cart on a final step and cart amount goes below 50, free shipping method still available. After this free shipping will be always available until you clean cookie

SerhiyShkolyarenko commented 7 years ago

@Tapin1 it seems to be fixed on the latest develop branch.

Tapin1 commented 7 years ago

Give me a link please

SerhiyShkolyarenko commented 7 years ago

sorry, which link do you mean?

Tapin1 commented 7 years ago

Where can I see fixed issues?

SerhiyShkolyarenko commented 7 years ago

I think console commands git clone https://github.com/magento/magento2.git . and git log will provide the complete list of fixes. If you have the cloned repository, git pull, git checkout develop and git log will be better for you.

SerhiyShkolyarenko commented 7 years ago

We are closing this issue because it hasn’t been updated in more than two weeks. If you can still reproduce this issue, please create a new GitHub issue report.