search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Greek vat numbers cannot be validated #6960

Closed schnappenberger closed 5 years ago

schnappenberger commented 8 years ago

Validation of vat numbers use country code to build a vat number for vat validation. But greek vat numbers start with EL instead of GR.

Preconditions

  1. Magento 2.1.1
  2. PHP7
  3. Mysql 5
  4. Apache 2

    Steps to reproduce

  5. login in frontend
  6. enter a valif greek vat id
  7. let magento validate the vat number

    Expected result

  8. correct vat numbers should be validated

    Actual result

  9. vat number validation fails
sevos1984 commented 8 years ago

Internal ticket created MAGETWO-59636. Thanks for posting

cmuench commented 7 years ago

Any updates here? We have the same problem with a valid the german VAT. If i remove the "DE" prefix it passes the validation. After the validation the "DE" prefix is automatically prepended. If i save my billing address again in the customer area the validation fails again.

magento-engcom-team commented 7 years ago

@schnappenberger, thank you for your report. We've created internal ticket(s) MAGETWO-59636 to track progress on the issue.

magento-engcom-team commented 6 years ago

Hi @schnappenberger

This ticket has been marked as "Triage Wanted" due to low user involvement over time. Over the next 2 weeks we are looking for additional community feedback to decide if it should be archived or not. More information on this is available on the GitHub wiki.

Thank you for collaboration.

magento-engcom-team commented 6 years ago

@schnappenberger thank you for your report.

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

You may learn more about this initiative following this link.

Please feel free to comment or reopen the ticket if you think it should be reviewed once more. Thank you for collaboration.

hostep commented 5 years ago

Re-opening, because a customer of ours runs against this problem with the incorrect Greek prefix. I'm currently preparing a PR to fix this.

@cmuench: I think the issue you are experiencing is not the same, but might have been fixed by: https://github.com/magento/magento2/pull/17385

magento-engcom-team commented 5 years ago

Hi @schnappenberger. Thank you for your report. The issue has been fixed in magento/magento2#20548 by @hostep in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team commented 5 years ago

Hi @schnappenberger. Thank you for your report. The issue has been fixed in magento/magento2#21169 by @amol2jcommerce in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming 2.2.9 release.