Price filter showing prices excluding taxes

pitangaweb commented 7 years ago

Preconditions

Magento 2.1.2 installed using composer
Steps to reproduce

Set catalog settings to show prices including taxes on front-end
Enable layered navigation by setting "is anchor" to yes on every categories
Expected result

Price filter on catalog pages should display price ranges including taxes.
Actual result

Price filter displays price ranges excluding taxes. Example: A product priced at 19€ excluding taxes and displayed at 24€ including taxes does show when the "10€ to 20€" price range is selected. It should show when the "20€ to 30€" price range is selected.

davidnguyen2205 commented 7 years ago

Same as my problem...

choukalos commented 7 years ago

Did you set the default or the website's shipping origin and tax default calculation to the same country? Did you also setup a tax rule that has an appropriate rate to it? It sounds like Magento thinks you uploaded the prices with tax (but found a 0% tax rate) and then is now dynamically adjusting the price based on the customer's tax rate (> 0% tax rate).

davidnguyen2205 commented 7 years ago

I checked that my config is right as you said. Can you reproduce it or not? :)

odubovyk commented 7 years ago

@pitangaweb, thank you for report. Internal ticket MAGETWO-60411

koenner01 commented 7 years ago

We have this problem too in 2.1.2 and I can confirm that this is still an issue after correcting the shipping origin & tax default calculation by setting them to the same country

developerscb commented 7 years ago

I can also confirm the same problem is happening in 2.1.3 and the things said by @choukalos are reviewed and not applying.

tal-girit commented 7 years ago

some problem with products with discount magento 2.1.2 and 2.1.3

hostep commented 7 years ago

We also saw this, but over here, the problem was caused by a free 3rd party extension which manipulates the filter functionality (Manadev). Digging through their code, they use prices excl tax for the price filtering. Disabling this 3rd party module seems to display the correct results over here.

ThisIsRuddy commented 7 years ago

Any news on this? We went live with M2 in December and had to disable our price filters due to it using the excluding tax price, causing major confusion for our customers. 2.1.6 and this is still the case, going to spin up a 2.1.7 and see if it is fixed there but I can only hope as this ticket is still open.

Image attached demonstrating behavior

price-filter-using-excluding-tax-value

EDIT: Just tried 2.1.7.... same problem price-filter-using-excluding-tax-value

RixXuan commented 7 years ago

@ThisIsRuddy your problem came from visualizing after taxed final price, here is quick solution, you can override method _getProductCollection from Magento\Catalog\Block\Product\ListProduct class by using your own ListProduct class, before return productCollection object, you can apply your own filter logic to filter again whole collection.

For instance, mention that price_filter in Magento using GET, you should see some param in URI like '?price=(min_price)-(max_price)' on category page, if things goes like this way, then you gen extract max price and iterate through product collection compare each of them with max price, remove product items has (price+tax) above filter range, like: foreach ($this->_productCollection as $key => $item) { // YOUR FILTER LOGIC // blah blah blah...

if(!$in_condition){ $this->_productCollection->removeItemByKey($key); } }

This solution works fine on my case, but still, it's a temporal solution, hope Magento team will make filter module more customizable.

Good luck!

veloraven commented 7 years ago

I'm closing this issue as internal ticket was closes as not a bug: layered navigation with prices including tax will multiply index size, also that will break manual Layered Navigation with fixed intervals if it's configured (i.e. 100-200, 200-300, 300-400). However you can submit this issue to Magento 2 Feature Requests and Improvements forum as improvement if you think it will have significant value (see details here). However I can not promise that it will be implemented even in this case.

pitangaweb commented 7 years ago

Well I can understand the implications, but I find it really weird that such an essential feature for the European market (and lots of countries) might never be implemented.

ThisIsRuddy commented 7 years ago

I too share this opinion 😐

On Tue, 20 Jun 2017, 09:27 pitangaweb, notifications@github.com wrote:

Well I can understand the implications, but I find it really weird that such an essential feature for the European market (and lots of countries) might never be implemented.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/7199#issuecomment-309682007, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrfk666E9PW343jAC-TeCZMA3mXet3hks5sF4KPgaJpZM4KhgFt .

GuidoHub commented 7 years ago

You are kidding me right? So the products are shown with tax and you are going to filter on excluding, how can you even think this is feature and not a bug. Have you ever looked at this on perspective of a customer? Oh I filter on price 20 but I never see products in that price range. What a disappointment.

ThisIsRuddy commented 7 years ago

@GuidoHub you tried 2.2 RC yet? I've not had a chance to

GuidoHub commented 7 years ago

@ThisIsRuddy No, still fighting with Magento 2.1.18, there are so many bugs and features that don't work for european market. Like when you use special price, the old price in catelog is shown without tax, how can you even think this is right. Magento is really working towards B2B instead of B2C

pitangaweb commented 7 years ago

Well it's crystal clear that Magento is ignoring the European market. Customers have a hard time understanding why basic features included in entry-level cart systems are not even in Magento 2's roadmap. I mean, we have to make a feature request to have a bug fixed, because the bug is actually a feature. How crazy is that ?

ThisIsRuddy commented 7 years ago

Ridiculous 😭😂

On Thu, 5 Oct 2017, 13:14 farhadfrz, notifications@github.com wrote:

Almost one year no fix?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/7199#issuecomment-334446361, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrfk-Wh7wO4pcrqZ3M3S3tkb0Ck7Lh6ks5spMgKgaJpZM4KhgFt .

orlangur commented 7 years ago

internal ticket was closes as not a bug: layered navigation with prices including tax will multiply index size, also that will break manual Layered Navigation with fixed intervals if it's configured (i.e. 100-200, 200-300, 300-400).

Anybody understand this? Isn't all we need is just having a BIG GLOBAL SWITCH saying whether layered navigation includes tax or not? Or the problem is that tax may vary from region to region and thus we would have to keep NxX compared to X size of original index?

korostii commented 6 years ago

also that will break manual Layered Navigation with fixed intervals if it's configured (i.e. 100-200, 200-300, 300-400)

Well, from the screenshots above it seems to me that it's broken already. Please note that "it seems complicated, we're worried we might break something else while fixing this bug" is not the same as "not a bug".

sebfie commented 6 years ago

Any update on this?

sandip5678 commented 6 years ago

Any news on this? We went live with M2 in December and had to disable our price filters due to it using the excluding tax price, causing major confusion for our customers. 2.1.6 and this is still the case, going to spin up a 2.1.7 and see if it is fixed there but I can only hope as this ticket is still open.

Image attached demonstrating behavior

EDIT: Just tried 2.1.7.... same problem

this issue still there in Magento latest version 2.2.5 and 2.2.6. Hope they will resolve in 2.3.0 release

Panda-Mathieu commented 5 years ago

Any news on this ?

orlangur commented 5 years ago

I would like to get some kind of an answer as well.

@veloraven could you please add some more details?

m2-assistant[bot] commented 5 years ago

Hi @engcom-backlog-nazar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99245 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

darshan-khatri-16 commented 5 years ago

Its fixed in 2.3.1

orlangur commented 5 years ago

@darshan-khatri-16 good to know, please add appropriate label then.

ghost commented 5 years ago

Hi @darshan-khatri-16 Unfortunately we also have this problem, but we use magento 2.3.1 .. Do you have any idea or tipp for what we should to do or try ? Maybe can you send a link where we can see the commit about this? Thank you!

darshan-khatri-16 commented 5 years ago

Hi @matekovacs-srg You just need to do a proper configuration in Magento admin. Also, set proper tax class while creating Product. I didn't find any particular commit for this issue fix.

jcodo commented 5 years ago

Is this actually fixed?

pitangaweb commented 5 years ago

I opened this issue almost 3 years ago. It's good to know that something has finally happened. I know it won't help anybody but I have to say that, after 10 years (!) on Magento, we have finally switched to another e-commerce platform that is actually opened to the possibility that there is life outside North America.

orlangur commented 5 years ago

@pitangaweb I bet such platform does not have even 50% of Magento abilities and has it's own pitfalls 😉

pitangaweb commented 5 years ago

@orlangur Every platform has its pitfalls for sure.

"I bet such platform does not have even 50% of Magento abilities"

Well, almost 3 years to finally have a basic feature like price filtering fixed does not inspire me to explore the other 50%.

orlangur commented 5 years ago

@pitangaweb it could be fixed by proper third-party developers if needed pretty quickly, probably not fixed by core developers because it is not a really frequent use case.

Anyway, good luck with a new platform of your choice and thanks for a bug report, such tiny steps help to improve Magento platform for sure.

jcodo commented 5 years ago

Can anyone here suggest how this new functionality might be switched on or configured? Can't work it out.

chickenland commented 5 years ago

Seeing this issue in 2.3.1 too - would be useful to know the correct setup suggested for this if it's config.

kevinvuillemin commented 5 years ago

Hello did you found a solution ?

bernd-reindl commented 4 years ago

Still in 2.3.5-p1

kevinvuillemin commented 4 years ago

Up please ?

bernd-reindl commented 4 years ago

@magento-engcom-team this bug is still in 2.3.5-p1.

pitangaweb commented 4 years ago

@pitangaweb [...] it is not a really frequent use case.

Yes, you're right, it only concerns the 750 million people of Europe, at least 27 countries. it is not a really frequent use case, right ? 😅

victortodoran commented 3 years ago

See Igors answer here https://magento.stackexchange.com/questions/176341/magento-2-layered-navigation-price-without-tax

pitangaweb commented 3 years ago

@victortodoran And that's a terrible answer. If "the current behavior is by design", then it was poorly designed.

zigojacko commented 3 years ago

2.4 user here and we've just noticed this problem - I find it absolutely ridiculous that Magento don't deem this a bug. It renders the price filter completely inaccurate - abysmal...!

Anyone know of a fix we can apply to put this right?

Rickertje commented 2 years ago

@magento-engcom-team Reopen this issue please

DaWheelz commented 1 year ago

This is still happening in 2.3.6... Can we please get a fix for this soon?

magento / magento2

Price filter showing prices excluding taxes #7199

Preconditions

Steps to reproduce

Expected result

Actual result