search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

[Magento =< 2.1.7] Translation for "Please specify a shipping method." not working. #9862

Closed royvanos closed 7 years ago

royvanos commented 7 years ago

Preconditions

  1. Magento CE 2.1.7 (probably any Magento 2 version)

Steps to reproduce

  1. Set up a store with demo content
  2. Enable multiple shipping methods
  3. Go directly to the checkout page by clicking the checkout button in the minicart popup
  4. Try going to the billing step without selecting a shipping method

Expected result

  1. Translation for "Please specify a shipping method." is translated

Actual result

  1. Translation for "Please specify a shipping method." is not translated

Changing magento/module-checkout/view/frontend/web/js/view/shipping.js from if (!quote.shippingMethod()) { this.errorValidationMessage('Please specify a shipping method.'); return false; } to if (!quote.shippingMethod()) { this.errorValidationMessage($.mage.__('Please specify a shipping method.')); return false; } does the job!

veloraven commented 7 years ago

@royvanos thank you for your report. Internal ticket was created for this issue - MAGETWO-69712

koenner01 commented 7 years ago

This was already fixed on the develop branch in MAGETWO-50289 (https://github.com/magento/magento2/commit/2477c5ca5fdac3c972e81835dc3550f6bdbaacc6)

magento-engcom-team commented 7 years ago

@royvanos, thank you for your report. The issue is already fixed in develop branch, 2.2.0