search

magento / marketplace-eqp

Magento 1.x Coding Standard
http://docs.magento.com/marketplace/user_guide/Resources/pdf/Extension_Quality_Program_Overview.pdf
MIT License
224 stars 68 forks source link

False positive "Unescaped output detected." #102

Closed ihor-sviziev closed 5 years ago

ihor-sviziev commented 5 years ago

Steps to reproduce

  1. Create phtml file with following content: 
    <?= /* @noEscape */ $jsonHelper->jsonEncode([]) ?>
  2. Run version magento marketplace-eqp version 2.0.0 against this file

Actual result:

------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Unescaped output detected.
---------------------------------------------------------------------------------------------------------------------------------------

Expected result: No errors should be. This warning should be ignored as we have @noEscape comment