Please specify the version of PHP_CodeSniffer in composer.json

[danslo]

The version that comes with Magento 2.1 (1.5.3) doesn't work with 1.0.1 of this repo.

[lenaorobei]

We added requirements to our README.md file.

[danslo]

But can you add them to composer.json? That's kinda what it's for ;-)

[ikruchynskyi]

@danslo Do you mean that we need to add it into "require" section? In case someone already has PHPCodesniffer - why he need to install another one? The main idea of custom standards is that they should be an addition to already exists Codesniffer standards.

[danslo]

Yeah, that's exactly what composer is for. If your repository doesn't work without that specific dependency, it has a _require_ment on it.

By your logic, why specify "php": ">=5.6.0", someone might already have PHP 5.4.

[ed007m]

@danslo Some of our sniffs doesn't work on php5.4.

[danslo]

And your code sniffs don't work at all without PHP_CodeSniffer.

[ed007m]

And what if someone already use PHP_CodeSniffer?

[danslo]

• In the case of standalone checkout of marketplace-eqp, it's not a problem since codesniffer lives in its own vendor directory.
• In the case of some main project which has dependency on marketplace-eqp and some specific version of codesniffer, this person should either;
  • relax their version requirement on codesniffer
  • choose between requiring marketplace-eqp or a lower version of codesniffer, not both

In any of the above cases, marketplace-eqp repo should still be specific about its own requirements.

[ed007m]

There is one more case - when PHP_CodeSniffer lives as it's own application. In that case person needs only to specify path to MEQP standards or path to other standard they what. Without installing PHP_CodeSniffer for each standard. As example you can look how PhpStorm works. After specifing path to phpcs, all what you need is just to set path to your custom standard and it is ready to use.

Marketplace-eqp is not a standalone application (for now). In future, everything can change, and, ofcourse, we will add this requirement to composer. But now, it's just a standard like many others.

[ed007m]

@danslo I'm sorry for late response. Actually, now we are reviewing your recommendation with our architects. And we will notify you as soon as.

[ed007m]

@danslo we reviewed your proposition and PHP_CodeSniffer version will be added to composer.json file in next release.

Thank you for reporting.

[danslo]

Thank you!