search

magento / marketplace-eqp

Magento 1.x Coding Standard
http://docs.magento.com/marketplace/user_guide/Resources/pdf/Extension_Quality_Program_Overview.pdf
MIT License
224 stars 68 forks source link

[WIP] Relative rule references #69

Closed giacmir closed 5 years ago

giacmir commented 6 years ago

I've changed the ruleset.xml file to use relative references so that these rules can be added as a dependency to an existing magento project with composer require --dev.

In this way you don't need to install rules globally and, together with a phpcs.xml file you can drop the setup time and complexity for other teammates, automated pipelines, and so on.

In the past I opened the very same issue in https://github.com/magento-ecg/coding-standard/issues/37

The only thing is that I'm not able to do and need some guidance is to split the MEQP1.Security.LanguageConstruct.DirectOutput Sniff to a different class since relative rule declaration works per file and not per rule.

lenaorobei commented 5 years ago

@giacmir I understand the reason you want to made this change, but we cannot accept this PR because MEQP1.Security.LanguageConstruct.DirectOutput will not work as expected.

We are working on Magento 2 sniffs consolidation and will take this issue into account for the future implementation.