magento / marketplace-eqp

Magento 1.x Coding Standard
http://docs.magento.com/marketplace/user_guide/Resources/pdf/Extension_Quality_Program_Overview.pdf
MIT License
224 stars 68 forks source link

MEQP1 does not working properly #73

Closed sankar1061 closed 6 years ago

sankar1061 commented 6 years ago

We have executed the below command,

phpcs --standard=MEQP1 module/

But throw below errors:

PHP Fatal error: Interface 'PHP_CodeSniffer\Sniffs\Sniff' not found in /var/www/marketplace-eqp-master/MEQP1/Sniffs/Classes/Mysql4Sniff.php on line 15

How to resolve this issue.

lenaorobei commented 6 years ago

Hello @sankar1061! Could you please provide steps to reproduce? Describe your environment (OS, PHP version, etc) and how you've installed MEQP standard?

sankar1061 commented 6 years ago

Helloo @lenaorobei

My system details. OS - Ubuntu 16.04.3 PHP - 7.0.18

MEQP installed below method. 1) I have download the marketplace-eqp-master package. 2) executed the commands ( sudo phpcs --config-set installed_paths /var/www/marketplace-eqp-master/ ). 3) Run the command phpcs -i 4) Displayed ( The installed coding standards are PSR1, MySource, PEAR, PSR2, PHPCS, Zend, Squiz, MEQP2 and MEQP1 )

lenaorobei commented 6 years ago

Did you run composer install inside marketplace-eqp-master folder?

sankar1061 commented 6 years ago

Yes already installed the composer

lenaorobei commented 6 years ago

I suspect you have phpcs installed globally, and you didn't install MEQP standard correctly. I mean, you need to:

  1. cd /var/www/marketplace-eqp-master
  2. Run composer install command to install all dependencies
  3. vendor/bin/phpcs --standard=MEQP1 module/
sankar1061 commented 6 years ago

One month before, I have check the same everything working fine. But now update the folder structure in marketplace-eqp-master. In marketplace-eqp-master added the MEQP/Utils folder. But one month before does not available. I have try to installed the old package and executed the MEQP1, all are working.

sankar1061 commented 6 years ago

Please refer the my old package >> marketplace-eqp-master.zip

lenaorobei commented 6 years ago

Yes, that's correct. We updated MEQP Standard by adding new dynamic sniffs and also installation steps were changed. Please follow the instruction.

sankar1061 commented 6 years ago

How to install the dynamic sniffs.

My system details. OS - Ubuntu 16.04.3 PHP - 7.0.18

lenaorobei commented 6 years ago

Installation instructions are available in README.md file.