search

magento / marketplace-eqp

Magento 1.x Coding Standard
http://docs.magento.com/marketplace/user_guide/Resources/pdf/Extension_Quality_Program_Overview.pdf
MIT License
224 stars 68 forks source link

Jenkins will not find any files because MEQP1 excludes all lib folders #81

Closed moleman closed 6 years ago

moleman commented 6 years ago

I found an issue with running the MEQP1 ruleset in Jenkins because the default Jenkins home directory is /var/lib/jenkins. This will cause <exclude-pattern>*/lib/*</exclude-pattern> to exclude all files because PHPCS will check the full absolute path which will always include lib in a default installation of Jenkins.

The only question I have with this fix is if it makes sense to have the exclude pattern at all.

lenaorobei commented 6 years ago

@moleman thank you for contribution. An answer to your question: for Magento 1.x projects we exclude lib folder because most of the commonly used libraries follow different coding standards and we cannot force developers into changing it in order to follow MEQP standard.