search

magento / marketplace-eqp

Magento 1.x Coding Standard
http://docs.magento.com/marketplace/user_guide/Resources/pdf/Extension_Quality_Program_Overview.pdf
MIT License
224 stars 68 forks source link

Abstract methods and "Use of protected class members is discouraged." #83

Closed likemusic closed 6 years ago

likemusic commented 6 years ago

There is impossible to have abstract private method in php. Therefore the message should not be displayed for them.

lenaorobei commented 6 years ago

The principle Composition over inheritance implies that you can build your architecture without the use of abstract methods. You can create an interface, implement it and inject via constructor. Please find more in the Magento Technical guidelines

likemusic commented 6 years ago

In this case, it would be more logical/obvious/informative to show a message like "Use of abstract classed is discouraged.".

lenaorobei commented 6 years ago

Thanks for the feedback. Will take it into account.